From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: RE: [RFC] mtd: nand: Fix bad block identification issue Date: Fri, 29 Apr 2011 20:44:44 +0300 Message-ID: <1304099084.2737.59.camel@localhost> References: <1303906161-24175-1-git-send-email-parth.saxena@ti.com> <1304011843.2737.3.camel@localhost> <19F8576C6E063C45BE387C64729E739404E1A21866@dbde02.ent.ti.com> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ew0-f46.google.com ([209.85.215.46]:47868 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760678Ab1D2Rs5 (ORCPT ); Fri, 29 Apr 2011 13:48:57 -0400 Received: by ewy4 with SMTP id 4so1218123ewy.19 for ; Fri, 29 Apr 2011 10:48:56 -0700 (PDT) In-Reply-To: <19F8576C6E063C45BE387C64729E739404E1A21866@dbde02.ent.ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Saxena, Parth" Cc: Brian Norris , "linux-mtd@lists.infradead.org" , "Basheer, Mansoor Ahamed" , "linux-omap@vger.kernel.org" On Fri, 2011-04-29 at 19:52 +0530, Saxena, Parth wrote: >=20 > > -----Original Message----- > > From: Artem Bityutskiy [mailto:dedekind1@gmail.com] > > Sent: Thursday, April 28, 2011 11:01 PM > > To: Saxena, Parth; Brian Norris > > Cc: linux-mtd@lists.infradead.org; Basheer, Mansoor Ahamed; linux- > > omap@vger.kernel.org > > Subject: Re: [RFC] mtd: nand: Fix bad block identification issue > >=20 > > On Wed, 2011-04-27 at 17:39 +0530, Saxena, Parth wrote: > > > This patch solves the above issue for omap by initialising > > > badblockbits. We are working further on this to find a generic fi= x > > > to the problem in nand_base.c. > >=20 > > But it looks like the generic solution is to return the line which = was > > accidentally removed, how about this patch > >=20 > > From: Artem Bityutskiy > > Date: Thu, 28 Apr 2011 20:26:59 +0300 > > Subject: [PATCH] mtd: return badblockbits back > >=20 > > In commit c7b28e25cb9beb943aead770ff14551b55fa8c79 the initializati= on of > > the backblockbits was accidentally removed. This patch returns it b= ack, > > because otherwise some NAND drivers are broken. > >=20 > > This problem was reported by "Saxena, Parth " = here: > > http://lists.infradead.org/pipermail/linux-mtd/2011-April/035221.ht= ml > >=20 > > Reported-by: Saxena, Parth > > Signed-off-by: Artem Bityutskiy > > Cc: stable@kernel.org [2.6.36+] > > --- > > drivers/mtd/nand/nand_base.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > >=20 > > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_b= ase.c > > index 15510f2..5a7f817 100644 > > --- a/drivers/mtd/nand/nand_base.c > > +++ b/drivers/mtd/nand/nand_base.c > > @@ -3106,6 +3106,8 @@ ident_done: > > chip->chip_shift +=3D 32 - 1; > > } > >=20 > > + chip->badblockbits =3D 8; > > + > > /* Set the bad block position */ > > if (mtd->writesize > 512 || (busw & NAND_BUSWIDTH_16)) > > chip->badblockpos =3D NAND_LARGE_BADBLOCK_POS; > [Saxena, Parth]=20 >=20 > Tested-By: Saxena, Parth > Acked By: Saxena, Parth Thanks, pushing to the l2-mtd-2.6.git. --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html