* [PATCH] Fix incorrect structure freeing in omap_nand_remove()
@ 2011-03-11 0:26 green
0 siblings, 0 replies; 2+ messages in thread
From: green @ 2011-03-11 0:26 UTC (permalink / raw)
To: linux-omap; +Cc: Oleg Drokin
From: Oleg Drokin <green@linuxhacker.ru>
Attempt to kfree(&info->mtd) is a bad idea since it's
a different substructure in the middle of a properly
allocated struct omap_nand_info.
I guess nobody tripped it before since nobody really
removes NAND flash and nobody unloads the module either.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
drivers/mtd/nand/omap2.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 4e33972..7c71716 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -1131,7 +1131,7 @@ static int omap_nand_remove(struct platform_device *pdev)
/* Release NAND device, its internal structures and partitions */
nand_release(&info->mtd);
iounmap(info->nand.IO_ADDR_R);
- kfree(&info->mtd);
+ kfree(info);
return 0;
}
--
1.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] Fix incorrect structure freeing in omap_nand_remove()
@ 2011-04-29 19:03 green
0 siblings, 0 replies; 2+ messages in thread
From: green @ 2011-04-29 19:03 UTC (permalink / raw)
To: linux-omap; +Cc: Artem Bityutskiy, Oleg Drokin
From: Oleg Drokin <green@linuxhacker.ru>
Attempt to kfree(&info->mtd) is a bad idea since it's
a different substructure in the middle of a properly
allocated struct omap_nand_info.
I guess nobody tripped it before since nobody really
removes NAND flash and nobody unloads the module either.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
drivers/mtd/nand/omap2.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index da9a351..39f5034 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -1139,7 +1139,7 @@ static int omap_nand_remove(struct platform_device *pdev)
/* Release NAND device, its internal structures and partitions */
nand_release(&info->mtd);
iounmap(info->nand.IO_ADDR_R);
- kfree(&info->mtd);
+ kfree(info);
return 0;
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-29 19:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-29 19:03 [PATCH] Fix incorrect structure freeing in omap_nand_remove() green
-- strict thread matches above, loose matches on Subject: below --
2011-03-11 0:26 green
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox