linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lesly Arackal Manuel <leslyam@ti.com>
To: linux-omap@vger.kernel.org
Cc: Lesly A M <leslyam@ti.com>, Samuel Ortiz <sameo@linux.intel.com>
Subject: [PATCH 1/1] OMAP: twl4030-power: In remove script check the error condition after i2cwrite
Date: Wed, 4 May 2011 17:38:53 +0530	[thread overview]
Message-ID: <1304510933-14488-1-git-send-email-leslyam@ti.com> (raw)

From: Lesly A M <leslyam@ti.com>

Fixing the error condition check in twl4030 remove script function.
Due to some typo in commit ID: 11a441ce82d6ffecfd39b324024de0cd630b36c1

Signed-off-by: Lesly A M <leslyam@ti.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>
---
 drivers/mfd/twl4030-power.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
index 16422de..6fed964 100644
--- a/drivers/mfd/twl4030-power.c
+++ b/drivers/mfd/twl4030-power.c
@@ -484,9 +484,9 @@ int twl4030_remove_script(u8 flags)
 			return err;
 	}
 	if (flags & TWL4030_WAKEUP12_SCRIPT) {
-		if (err)
 		err = twl_i2c_write_u8(TWL4030_MODULE_PM_MASTER, END_OF_SCRIPT,
 				R_SEQ_ADD_S2A12);
+		if (err)
 			return err;
 	}
 	if (flags & TWL4030_WAKEUP3_SCRIPT) {
-- 
1.7.1


             reply	other threads:[~2011-05-04 12:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-04 12:08 Lesly Arackal Manuel [this message]
2011-05-13 17:08 ` [PATCH 1/1] OMAP: twl4030-power: In remove script check the error condition after i2cwrite Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304510933-14488-1-git-send-email-leslyam@ti.com \
    --to=leslyam@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).