linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [Patch v1] AM35xx-Craneboard:Update
@ 2011-05-05  7:15 srinath
  2011-05-05  8:46 ` Igor Grinberg
  0 siblings, 1 reply; 2+ messages in thread
From: srinath @ 2011-05-05  7:15 UTC (permalink / raw)
  To: linux-omap
  Cc: linux, umeshk, tony, nagendra, Srinath.R, linux-kernel, khilman,
	jdk, linux-arm-kernel

From: Srinath.R <srinath@mistralsolutions.com>

Replaced gpio_request()/gpio_direction_output() with gpio_request_one() in am3517_crane_init.

Signed-off-by: Srinath.R <srinath@mistralsolutions.com>
---
 arch/arm/mach-omap2/board-am3517crane.c |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c
index a890d24..b8c7150 100644
--- a/arch/arm/mach-omap2/board-am3517crane.c
+++ b/arch/arm/mach-omap2/board-am3517crane.c
@@ -89,19 +89,13 @@ static void __init am3517_crane_init(void)
 		return;
 	}
 
-	ret = gpio_request(GPIO_USB_POWER, "usb_ehci_enable");
+	ret = gpio_request_one(GPIO_USB_POWER, GPIOF_OUT_INIT_HIGH,
+				"usb_ehci_enable");
 	if (ret < 0) {
 		pr_err("Can not request GPIO %d\n", GPIO_USB_POWER);
 		return;
 	}
 
-	ret = gpio_direction_output(GPIO_USB_POWER, 1);
-	if (ret < 0) {
-		gpio_free(GPIO_USB_POWER);
-		pr_err("Unable to initialize EHCI power\n");
-		return;
-	}
-
 	usbhs_init(&usbhs_bdata);
 }
 
-- 
1.5.3.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch v1] AM35xx-Craneboard:Update
  2011-05-05  7:15 [Patch v1] AM35xx-Craneboard:Update srinath
@ 2011-05-05  8:46 ` Igor Grinberg
  0 siblings, 0 replies; 2+ messages in thread
From: Igor Grinberg @ 2011-05-05  8:46 UTC (permalink / raw)
  To: srinath
  Cc: linux-omap, jdk, tony, linux-kernel, linux, linux-arm-kernel,
	khilman, nagendra, umeshk

Hi Srinath,


On 05/05/11 10:15, srinath@mistralsolutions.com wrote:

> From: Srinath.R <srinath@mistralsolutions.com>
>
> Replaced gpio_request()/gpio_direction_output() with gpio_request_one() in am3517_crane_init.

This has been already done and waits for Tony to apply.
Please, see:
http://www.spinics.net/lists/arm-kernel/msg123823.html


-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-05  8:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-05  7:15 [Patch v1] AM35xx-Craneboard:Update srinath
2011-05-05  8:46 ` Igor Grinberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).