From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Amber Jain <amber@ti.com>
Cc: linux-omap@vger.kernel.org, molnar@ti.com
Subject: Re: [PATCH 4/5] OMAP: DSS2: Adds new registers for NV12 support
Date: Thu, 19 May 2011 09:45:18 +0300 [thread overview]
Message-ID: <1305787518.1849.34.camel@deskari> (raw)
In-Reply-To: <1305783090-21214-5-git-send-email-amber@ti.com>
On Thu, 2011-05-19 at 11:01 +0530, Amber Jain wrote:
> Adds new register definitions and simple helper functions to configure them.
Remember that the subject and the description are separate things. Even
if you mention NV12 in the subject, the description also should be
"whole" and mention NV12, as the line above doesn't really say anything
what kind of registers are being added. And this is not only about NV12,
it's also about the new scaling config thingie for the old YUV modes.
And it wouldn't hurt to tell a bit more about the registers, as their
use is not very clear. The reader should of course look at the TRM to
get full understanding of the subject, but it would be good to briefly
explain the UV plane registers and how it affects things.
> Added these new registers to save/restore and DUMPREG fumction.
> Also adds two new features FEAT_HANDLE_UV_SEPARATE and FEAT_ATTR2.
What do the features do and on what platforms are they enabled?
Tomi
next prev parent reply other threads:[~2011-05-19 6:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 5:31 [PATCH 0/5] OMAP: DSS2: Add suppport for new color format Amber Jain
2011-05-19 5:31 ` [PATCH 1/5] OMAP: DSS2: Add new color formats Amber Jain
2011-05-19 6:12 ` Tomi Valkeinen
2011-05-19 5:31 ` [PATCH 2/5] OMAP: DSS2: configuring non-zero values for fir_hinc/fir_vinc Amber Jain
2011-05-19 6:34 ` Tomi Valkeinen
2011-05-19 5:31 ` [PATCH 3/5] OMAP: DSS2: Use for loop where ever possible in SR(), RR(), DUMPREG() Amber Jain
2011-05-19 5:31 ` [PATCH 4/5] OMAP: DSS2: Adds new registers for NV12 support Amber Jain
2011-05-19 6:45 ` Tomi Valkeinen [this message]
2011-05-19 5:31 ` [PATCH 5/5] OMAP: DSS2: Add support for NV12 format Amber Jain
2011-05-19 6:51 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305787518.1849.34.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=amber@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=molnar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox