From: Kevin Hilman <khilman@ti.com>
To: linux-omap@vger.kernel.org
Cc: p-titiano@ti.com
Subject: [PATCH/RFC 1/4] OMAP3: PM debug: remove sleep_while_idle feature
Date: Thu, 26 May 2011 16:02:48 -0700 [thread overview]
Message-ID: <1306450971-27732-2-git-send-email-khilman@ti.com> (raw)
In-Reply-To: <1306450971-27732-1-git-send-email-khilman@ti.com>
Remove the OMAP-specific PM debug 'sleep_while_idle' feature which is
currently available as an OMAP-specific debugfs entry.
This duplicates existing ARM-generic functionality available as a
boot-time option using the boot cmdline option 'hohlt'.
If runtime configuration of this is needed, then adding a debugfs
entry for the ARM-generic hlt/nohlt interface should be added.
Signed-off-by: Kevin Hilman <khilman@ti.com>
---
arch/arm/mach-omap2/pm-debug.c | 3 ---
arch/arm/mach-omap2/pm.h | 2 --
arch/arm/mach-omap2/pm34xx.c | 2 --
3 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
index a5a83b3..cf9bc15 100644
--- a/arch/arm/mach-omap2/pm-debug.c
+++ b/arch/arm/mach-omap2/pm-debug.c
@@ -40,7 +40,6 @@
int omap2_pm_debug;
u32 enable_off_mode;
-u32 sleep_while_idle;
u32 wakeup_timer_seconds;
u32 wakeup_timer_milliseconds;
@@ -639,8 +638,6 @@ static int __init pm_dbg_init(void)
(void) debugfs_create_file("enable_off_mode", S_IRUGO | S_IWUSR, d,
&enable_off_mode, &pm_dbg_option_fops);
- (void) debugfs_create_file("sleep_while_idle", S_IRUGO | S_IWUSR, d,
- &sleep_while_idle, &pm_dbg_option_fops);
(void) debugfs_create_file("wakeup_timer_seconds", S_IRUGO | S_IWUSR, d,
&wakeup_timer_seconds, &pm_dbg_option_fops);
(void) debugfs_create_file("wakeup_timer_milliseconds",
diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
index 797bfd1..fc2377c 100644
--- a/arch/arm/mach-omap2/pm.h
+++ b/arch/arm/mach-omap2/pm.h
@@ -64,13 +64,11 @@ extern void omap2_pm_dump(int mode, int resume, unsigned int us);
extern void omap2_pm_wakeup_on_timer(u32 seconds, u32 milliseconds);
extern int omap2_pm_debug;
extern u32 enable_off_mode;
-extern u32 sleep_while_idle;
#else
#define omap2_pm_dump(mode, resume, us) do {} while (0);
#define omap2_pm_wakeup_on_timer(seconds, milliseconds) do {} while (0);
#define omap2_pm_debug 0
#define enable_off_mode 0
-#define sleep_while_idle 0
#endif
#if defined(CONFIG_CPU_IDLE)
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 0c5e3a4..991ade6 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -497,8 +497,6 @@ console_still_active:
int omap3_can_sleep(void)
{
- if (!sleep_while_idle)
- return 0;
if (!omap_uart_can_sleep())
return 0;
return 1;
--
1.7.4
next prev parent reply other threads:[~2011-05-26 22:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 23:02 [PATCH/RFC 0/4] OMAP: PM debug: remove register dump, misc cleanups Kevin Hilman
2011-05-26 23:02 ` Kevin Hilman [this message]
2011-05-27 7:37 ` [PATCH/RFC 1/4] OMAP3: PM debug: remove sleep_while_idle feature Jean Pihet
2011-05-27 15:26 ` Kevin Hilman
2011-05-27 16:01 ` Jean Pihet
2011-05-30 7:15 ` Santosh Shilimkar
2011-05-30 7:59 ` Jean Pihet
2011-05-26 23:02 ` [PATCH/RFC 2/4] OMAP2: PM debug: remove register dumping Kevin Hilman
2011-05-30 7:17 ` Santosh Shilimkar
2011-06-01 1:34 ` Kevin Hilman
2011-05-30 8:05 ` Jean Pihet
2011-05-31 8:24 ` Titiano, Patrick
2011-06-01 1:40 ` Kevin Hilman
2011-06-01 14:28 ` Titiano, Patrick
2011-05-26 23:02 ` [PATCH/RFC 3/4] OMAP3: " Kevin Hilman
2011-05-30 7:18 ` Santosh Shilimkar
2011-05-30 8:06 ` Jean Pihet
2011-05-26 23:02 ` [PATCH/RFC 4/4] OMAP2: PM debug: move wakeup timer into clockevent code Kevin Hilman
2011-05-27 5:18 ` Santosh Shilimkar
2011-05-30 7:21 ` Santosh Shilimkar
2011-05-30 8:08 ` Jean Pihet
2011-05-30 8:10 ` Santosh Shilimkar
2011-05-27 7:34 ` [PATCH/RFC 0/4] OMAP: PM debug: remove register dump, misc cleanups Jean Pihet
2011-05-27 15:00 ` Kevin Hilman
2011-06-13 12:28 ` Santosh Shilimkar
2011-06-16 0:33 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306450971-27732-2-git-send-email-khilman@ti.com \
--to=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=p-titiano@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).