From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 19/27] OMAP: DSS2: Use PM runtime & HWMOD support Date: Tue, 07 Jun 2011 12:08:36 +0300 Message-ID: <1307437716.1858.19.camel@deskari> References: <1307095237-14805-1-git-send-email-tomi.valkeinen@ti.com> <1307095237-14805-20-git-send-email-tomi.valkeinen@ti.com> <871uzahnib.fsf@ti.com> <1307122985.2016.72.camel@deskari> <87hb86a5mm.fsf@ti.com> <1307174504.1777.24.camel@lappyti> <4DECCE90.6070201@ti.com> <1307365290.1910.39.camel@deskari> <4DECD2D7.6030207@ti.com> <1307366474.1910.44.camel@deskari> <4DECDA3A.7080808@ti.com> <1307368525.1910.50.camel@deskari> <4DECF215.5020505@ti.com> <1307429547.1858.10.camel@deskari> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aob106.obsmtp.com ([74.125.149.76]:56582 "EHLO na3sys009aog106.obsmtp.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751834Ab1FGJIm (ORCPT ); Tue, 7 Jun 2011 05:08:42 -0400 In-Reply-To: <1307429547.1858.10.camel@deskari> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Cousson, Benoit" Cc: "Hilman, Kevin" , "linux-omap@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "paul@pwsan.com" On Tue, 2011-06-07 at 09:52 +0300, Tomi Valkeinen wrote: > On Mon, 2011-06-06 at 17:28 +0200, Cousson, Benoit wrote: > > > Before doing that, could you maybe just try something to make OMAP4 > > looks a little bit more like OMAP3? > > > > dss_fck -> ick > > dss_dss_fck -> main_clk > > > > That should ensure that both modulemode and the PRCM fclk will be > > managed by pm_runtime. > > I made the changes as you suggested, and while I haven't made the > changes to omapdss yet to see if I can remove the dispc_runtime_get/put > style function, I can boot up and start the dss. > > However, after booting up but before enabling the dss driver, I can see > that the clock counts are: > > dss_tv_clk 0 > dss_sys_clk 0 > dss_fck 7 > dss_dss_clk 0 > dss_48mhz_clk 0 > > So the modulemode is set for all dss hwmods? Isn't this exactly how it's > _not_ meant to be, as modulemode should be set only after enabling the > fck? This also seems to keep the DSS from going to RET or OFF, at least in the TI internal PM testing tree. So is the PM side buggy there, and it shouldn't care about the modulemode being enabled if other clocks are off, or is it the hwmod side that's buggy, and it should disable the modulemode also? Tomi