From: Carlos Chinea <carlos.chinea@nokia.com>
To: ext Tony Lindgren <tony@atomide.com>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [RFC PATCHv5 2/7] HSI: omap_ssi: Introducing OMAP SSI driver
Date: Tue, 14 Jun 2011 15:09:22 +0300 [thread overview]
Message-ID: <1308053362.2819.38112.camel@groo> (raw)
In-Reply-To: <20110613132152.GA3352@atomide.com>
Hi,
-- cut--
> > +
> > +static int __init ssi_init(void)
> > +{
> > + return platform_device_register(&ssi_pdev);
> > +}
> > +subsys_initcall(ssi_init);
>
> Looks like you need something here also to prevent this subsys_initcall
> on running on all boards. Maybe have a pointer to ssi_pdev that only
> gets initialized after omap_ssi_config?
>
> Then you can have ssi_init fail if no configuration is called:
>
> if (!pdev)
> return -ENODEV;
>
> return platform_device_register(pdev);
>
Right. I'll do those changes.
Thanks,
Carlos
next prev parent reply other threads:[~2011-06-14 12:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 13:38 [RFC PATCHv5 0/7] HSI framework and drivers Carlos Chinea
2011-06-10 13:38 ` [RFC PATCHv5 1/7] HSI: hsi: Introducing HSI framework Carlos Chinea
2011-06-10 13:38 ` [RFC PATCHv5 2/7] HSI: omap_ssi: Introducing OMAP SSI driver Carlos Chinea
2011-06-13 13:21 ` Tony Lindgren
2011-06-14 12:09 ` Carlos Chinea [this message]
2011-06-13 20:21 ` Kevin Hilman
2011-06-14 12:12 ` Carlos Chinea
2011-06-15 15:37 ` Kevin Hilman
2011-06-10 13:38 ` [RFC PATCHv5 3/7] HSI: omap_ssi: Add OMAP SSI to the kernel configuration Carlos Chinea
2011-06-10 13:38 ` [RFC PATCHv5 4/7] HSI: hsi_char: Add HSI char device driver Carlos Chinea
2011-06-22 19:37 ` Sjur Brændeland
2011-06-23 9:12 ` Carlos Chinea
2011-06-10 13:38 ` [RFC PATCHv5 5/7] HSI: hsi_char: Add HSI char device kernel configuration Carlos Chinea
2011-06-10 13:38 ` [RFC PATCHv5 6/7] HSI: Add HSI API documentation Carlos Chinea
2011-06-10 13:38 ` [RFC PATCHv5 7/7] HSI: hsi_char: Update ioctl-number.txt Carlos Chinea
2011-06-14 9:35 ` [RFC PATCHv5 0/7] HSI framework and drivers Alan Cox
2011-06-15 9:27 ` Andras Domokos
2011-06-22 19:11 ` [RFC PATCHv5 1/7] HSI: hsi: Introducing HSI framework Sjur Brændeland
2011-06-22 19:25 ` Linus Walleij
2011-06-23 13:08 ` Carlos Chinea
2011-06-28 13:05 ` Sjur BRENDELAND
2011-07-22 10:43 ` Carlos Chinea
2011-07-22 11:01 ` Felipe Balbi
2011-07-22 11:51 ` Carlos Chinea
2011-07-22 12:05 ` Felipe Balbi
2011-07-22 13:02 ` Carlos Chinea
2011-07-24 21:56 ` Sjur Brændeland
2011-07-25 9:17 ` Carlos Chinea
2011-10-20 12:57 ` [RFC PATCHv5 0/7] HSI framework and drivers Sebastian Reichel
2011-10-21 9:54 ` Linus Walleij
2011-10-21 10:28 ` Carlos Chinea
2011-10-21 12:19 ` Linus Walleij
2011-10-21 13:36 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308053362.2819.38112.camel@groo \
--to=carlos.chinea@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).