From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
linux@arm.linux.org.uk, tony@atomide.com, lethal@linux-sh.org,
linaro-dev@lists.linaro.org, patches@linaro.org,
Samreen <samreen@ti.com>
Subject: Re: [PATCH 1/2] config: omap2+: force fb and dss support as built-in
Date: Mon, 20 Jun 2011 16:04:46 +0300 [thread overview]
Message-ID: <1308575086.2076.55.camel@deskari> (raw)
In-Reply-To: <1308566761-2850-2-git-send-email-tushar.behera@linaro.org>
On Mon, 2011-06-20 at 16:16 +0530, Tushar Behera wrote:
> In certain board files, there are references to vram related functions
> which are defined in drivers/video/omap2/vram.c. Because of this direct
> dependency, CONFIG_FB_OMAP2 should be a built-in feature.
arch/arm/plat-omap/include/plat/vram.h defines dummy inline function in
case vram.c is not compiled in, so the board files should compile fine.
> As per the current architecture, CONFIG_FB_OMAP2 is dependent on
> CONFIG_OMAP2_DSS. Hence CONFIG_OMAP2_DSS support should also be selected
> by default.
The configuration is fine as it is. And anyway, if things do not compile
when something is configured as a module, the correct fix is hardly just
changing the feature to be compiled built-in =).
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Samreen <samreen@ti.com>
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> arch/arm/mach-omap2/built-in.o: In function `rx51_video_mem_init':
> linux-linaro-2.6.39/arch/arm/mach-omap2/board-rx51-video.c:97: undefined reference to `omap_vram_set_sdram_vram'
> arch/arm/plat-omap/built-in.o: In function `omap_reserve':
> linux-linaro-2.6.39/arch/arm/plat-omap/common.c:66: undefined reference to `omap_vram_reserve_sdram_memblock'
> arch/arm/plat-omap/built-in.o: In function `omap_detect_sram':
> linux-linaro-2.6.39/arch/arm/plat-omap/sram.c:179: undefined reference to `omap_vram_reserve_sram'
> make[1]: *** [.tmp_vmlinux1] Error 1
> make: *** [sub-make] Error 2
Compiles fine for me. Perhaps you are using some old kernel?
Tomi
next prev parent reply other threads:[~2011-06-20 13:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 10:45 [PATCH 0/2] video: Make omap2 support conditional Tushar Behera
2011-06-20 10:46 ` [PATCH 1/2] config: omap2+: force fb and dss support as built-in Tushar Behera
2011-06-20 12:07 ` Premi, Sanjeev
[not found] ` <B85A65D85D7EB246BE421B3FB0FBB593024D625A5C@dbde02.ent.ti.com>
2011-06-20 12:20 ` Russell King - ARM Linux
2011-06-20 12:24 ` Premi, Sanjeev
2011-06-20 13:04 ` Tomi Valkeinen [this message]
2011-06-21 5:00 ` Tushar Behera
2011-06-20 10:46 ` [PATCH 2/2] video: omap2: Compile omap2 support only when needed Tushar Behera
2011-06-20 13:06 ` Tomi Valkeinen
2011-06-21 4:48 ` Tushar Behera
[not found] ` <4E0022B5.9000500-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-06-21 5:24 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308575086.2076.55.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=lethal@linux-sh.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@linaro.org \
--cc=samreen@ti.com \
--cc=tony@atomide.com \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox