From: jean.pihet@newoldbits.com
To: "Rafael J. Wysocki" <rjw@sisk.pl>, Paul Walmsley <paul@pwsan.com>,
Kevin Hilman <khilman@ti.com>,
Magnus Damm <magnus.damm@gmail.com>,
Linux PM mailing list <linux-pm@lists.linux-foun>
Cc: Jean Pihet <j-pihet@ti.com>
Subject: [PATCH 05/11] OMAP PM: early init of the pwrdms states
Date: Thu, 30 Jun 2011 17:11:19 +0200 [thread overview]
Message-ID: <1309446685-17502-6-git-send-email-j-pihet@ti.com> (raw)
In-Reply-To: <1309446685-17502-1-git-send-email-j-pihet@ti.com>
From: Jean Pihet <j-pihet@ti.com>
The powerdomains next states are initialized in pwrdms_setup as a
late_initcall. Because the wake-up constraint can be requested
early in the boot sequence, the power domains next states can be
overwritten by pwrdms_setup.
This patch fixes it by initializing the power domains next states
early at boot, so that the constraints can be applied.
Later in the pwrdms_setup function the currently programmed
next states are re-used as next state values.
Applies to OMAP3 and OMAP4.
Tested on OMAP3 Beagleboard and OMAP4 Pandaboard in RET/OFF using
wake-up latency constraints on MPU, CORE and PER.
Signed-off-by: Jean Pihet <j-pihet@ti.com>
---
arch/arm/mach-omap2/pm34xx.c | 2 +-
arch/arm/mach-omap2/pm44xx.c | 2 +-
arch/arm/mach-omap2/powerdomain.c | 3 +++
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index c155c9d..0b0a842 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -828,7 +828,7 @@ static int __init pwrdms_setup(struct powerdomain *pwrdm, void *unused)
if (!pwrst)
return -ENOMEM;
pwrst->pwrdm = pwrdm;
- pwrst->next_state = PWRDM_POWER_RET;
+ pwrst->next_state = pwrdm_read_next_pwrst(pwrdm);
list_add(&pwrst->node, &pwrst_list);
if (pwrdm_has_hdwr_sar(pwrdm))
diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c
index 59a870b..91ede72 100644
--- a/arch/arm/mach-omap2/pm44xx.c
+++ b/arch/arm/mach-omap2/pm44xx.c
@@ -84,7 +84,7 @@ static int __init pwrdms_setup(struct powerdomain *pwrdm, void *unused)
if (!pwrst)
return -ENOMEM;
pwrst->pwrdm = pwrdm;
- pwrst->next_state = PWRDM_POWER_ON;
+ pwrst->next_state = pwrdm_read_next_pwrst(pwrdm);
list_add(&pwrst->node, &pwrst_list);
return pwrdm_set_next_pwrst(pwrst->pwrdm, pwrst->next_state);
diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
index 9af0847..63c3e7a 100644
--- a/arch/arm/mach-omap2/powerdomain.c
+++ b/arch/arm/mach-omap2/powerdomain.c
@@ -108,6 +108,9 @@ static int _pwrdm_register(struct powerdomain *pwrdm)
pwrdm->state = pwrdm_read_pwrst(pwrdm);
pwrdm->state_counter[pwrdm->state] = 1;
+ /* Early init of the next power state */
+ pwrdm_set_next_pwrst(pwrdm, PWRDM_POWER_RET);
+
pr_debug("powerdomain: registered %s\n", pwrdm->name);
return 0;
--
1.7.4.1
next prev parent reply other threads:[~2011-06-30 15:11 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 15:11 [PATCH v2 00/11] PM QoS: add a per-device wake-up latency constraint class jean.pihet
2011-06-30 15:11 ` [PATCH 01/11] PM: add a per-device wake-up latency constraints plist jean.pihet
2011-07-02 19:39 ` Rafael J. Wysocki
2011-07-20 8:57 ` Jean Pihet
2011-06-30 15:11 ` [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints jean.pihet
2011-07-02 21:10 ` Rafael J. Wysocki
2011-07-20 9:13 ` Jean Pihet
2011-08-02 17:49 ` Kevin Hilman
2011-08-02 20:19 ` Rafael J. Wysocki
2011-08-02 21:23 ` Kevin Hilman
2011-08-02 22:16 ` Rafael J. Wysocki
2011-08-04 13:24 ` [linux-pm] " Mark Brown
2011-08-04 19:15 ` Rafael J. Wysocki
2011-08-05 15:29 ` mark gross
2011-08-05 16:11 ` Mark Brown
2011-08-05 19:37 ` Rafael J. Wysocki
2011-08-06 3:37 ` Mark Brown
2011-08-06 19:46 ` Rafael J. Wysocki
2011-08-07 2:47 ` [linux-pm] " Mark Brown
2011-08-08 21:31 ` Rafael J. Wysocki
2011-08-19 3:11 ` Mark Brown
2011-08-19 20:42 ` Rafael J. Wysocki
2011-08-19 23:14 ` Mark Brown
2011-08-20 2:24 ` Alan Stern
2011-08-20 6:25 ` Mark Brown
2011-08-20 13:48 ` Alan Stern
2011-08-20 15:30 ` Mark Brown
2011-08-20 16:34 ` Rafael J. Wysocki
2011-08-20 17:04 ` Mark Brown
2011-08-20 19:14 ` Rafael J. Wysocki
2011-08-21 8:25 ` Mark Brown
2011-08-21 18:05 ` Rafael J. Wysocki
2011-08-23 9:21 ` Mark Brown
2011-08-23 21:31 ` Rafael J. Wysocki
2011-08-25 10:38 ` Mark Brown
2011-08-25 14:17 ` Rafael J. Wysocki
2011-08-25 14:41 ` Jean Pihet
2011-08-25 14:49 ` Rafael J. Wysocki
2011-08-26 16:40 ` mark gross
2011-08-20 9:35 ` Rafael J. Wysocki
2011-08-20 10:31 ` Mark Brown
2011-08-20 16:51 ` Rafael J. Wysocki
2011-08-20 17:22 ` Mark Brown
2011-08-20 19:18 ` Rafael J. Wysocki
2011-08-26 2:25 ` MyungJoo Ham
2011-08-26 16:54 ` mark gross
2011-08-26 20:56 ` Rafael J. Wysocki
2011-06-30 15:11 ` [PATCH 03/11] PM QoS: support the dynamic devices insertion and removal jean.pihet
2011-07-02 21:14 ` Rafael J. Wysocki
2011-07-20 9:16 ` Jean Pihet
2011-06-30 15:11 ` [PATCH 04/11] OMAP PM: create a PM layer plugin for per-device constraints jean.pihet
2011-06-30 15:11 ` jean.pihet [this message]
2011-06-30 15:11 ` [PATCH 06/11] OMAP2+: powerdomain: control power domains next state jean.pihet
2011-06-30 15:11 ` [PATCH 07/11] OMAP3: powerdomain data: add wake-up latency figures jean.pihet
2011-06-30 15:11 ` [PATCH 08/11] OMAP4: " jean.pihet
2011-06-30 15:11 ` [PATCH 09/11] OMAP2+: omap_hwmod: manage the wake-up latency constraints jean.pihet
2011-06-30 15:11 ` [PATCH 10/11] OMAP: PM CONSTRAINTS: implement the devices " jean.pihet
2011-06-30 15:11 ` [PATCH 11/11] OMAP2+: cpuidle only influences the MPU state jean.pihet
2011-07-02 19:20 ` [PATCH v2 00/11] PM QoS: add a per-device wake-up latency constraint class Rafael J. Wysocki
2011-07-04 7:16 ` Vishwanath Sripathy
2011-07-04 8:38 ` Rafael J. Wysocki
2011-07-20 9:26 ` Jean Pihet
2011-07-20 13:22 ` mark gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309446685-17502-6-git-send-email-j-pihet@ti.com \
--to=jean.pihet@newoldbits.com \
--cc=j-pihet@ti.com \
--cc=khilman@ti.com \
--cc=linux-pm@lists.linux-foun \
--cc=magnus.damm@gmail.com \
--cc=paul@pwsan.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).