From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v2 17/18] OMAP4: hwmod data: Modify DSS opt clocks Date: Sat, 02 Jul 2011 12:13:57 +0300 Message-ID: <1309598037.1846.3.camel@deskari> References: <1309552901-8944-1-git-send-email-b-cousson@ti.com> <1309552901-8944-18-git-send-email-b-cousson@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog123.obsmtp.com ([74.125.149.149]:38798 "EHLO na3sys009aog123.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752705Ab1GBJOC (ORCPT ); Sat, 2 Jul 2011 05:14:02 -0400 Received: by mail-bw0-f45.google.com with SMTP id 12so5059823bwd.18 for ; Sat, 02 Jul 2011 02:14:01 -0700 (PDT) In-Reply-To: <1309552901-8944-18-git-send-email-b-cousson@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Benoit Cousson Cc: paul@pwsan.com, rnayak@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Hi Benoit, On Fri, 2011-07-01 at 22:41 +0200, Benoit Cousson wrote: > From: Tomi Valkeinen > > Add missing DSS optional clocks to HWMOD data for OMAP4xxx. > > Add HWMOD_CONTROL_OPT_CLKS_IN_RESET flag for dispc to fix dispc reset. > > Signed-off-by: Tomi Valkeinen > [b-cousson@ti.com: Remove a comment and update the subject] > Signed-off-by: Benoit Cousson This patch adds "fck" opt-clocks for DSS. After your patch set for_3.1/5_auto_fck_clkdev, in which you create "fck" automatically, I see: [ 0.218231] omap_device: omapdss_dss: fck already exist [ 0.218261] omap_device: omapdss_dss: fck already exist [ 0.218261] omap_device: omapdss_dss: sys_clk already exist [ 0.218261] omap_device: omapdss_dss: tv_clk already exist [ 0.218322] omap_device: omapdss_dss: video_clk already exist [ 0.218627] omap_device: omapdss_dispc: fck already exist [ 0.219329] omap_device: omapdss_venc: fck already exist [ 0.219635] omap_device: omapdss_dsi1: fck already exist [ 0.219970] omap_device: omapdss_dsi2: fck already exist [ 0.220336] omap_device: omapdss_hdmi: fck already exist So I think the "fck" clocks in this patch should be removed. I only added them for compatibility, as I didn't have the automatic "fck" creation patch in my tree. Also, either you didn't email the patch set in for_3.1/5_auto_fck_clkdev, or I'm just blind... Tomi