public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Linux OMAP Mailing List" <linux-omap@vger.kernel.org>,
	"Michael Büsch" <mb@bu3sch.de>, "Felipe Balbi" <balbi@ti.com>
Subject: [PATCH 21/22] cbus: tahvo: drop backlight interfaces
Date: Mon, 11 Jul 2011 14:17:34 +0300	[thread overview]
Message-ID: <1310383055-20211-22-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1310383055-20211-1-git-send-email-balbi@ti.com>

they aren't used by anyone and they should
be, anyways, on a child LED driver not on
core Tahvo.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 drivers/cbus/tahvo.c |   51 +-------------------------------------------------
 drivers/cbus/tahvo.h |    3 --
 2 files changed, 1 insertions(+), 53 deletions(-)

diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c
index 12d95ac..784431c 100644
--- a/drivers/cbus/tahvo.c
+++ b/drivers/cbus/tahvo.c
@@ -51,7 +51,6 @@ struct tahvo {
 	int		ack;
 	int		mask;
 
-	unsigned int	wide_backlight:1;
 	unsigned int	mask_pending:1;
 	unsigned int	ack_pending:1;
 	unsigned int	is_betty:1;
@@ -133,42 +132,6 @@ void tahvo_set_clear_reg_bits(struct device *child, unsigned reg, u16 set,
 	mutex_unlock(&tahvo->mutex);
 }
 
-int tahvo_get_backlight_level(void)
-{
-	struct tahvo		*tahvo = the_tahvo;
-	int			mask;
-
-	if (tahvo->wide_backlight)
-		mask = 0x7f;
-	else
-		mask = 0x0f;
-	return __tahvo_read_reg(tahvo, TAHVO_REG_LEDPWMR) & mask;
-}
-EXPORT_SYMBOL(tahvo_get_backlight_level);
-
-int tahvo_get_max_backlight_level(void)
-{
-	struct tahvo		*tahvo = the_tahvo;
-
-	if (tahvo->wide_backlight)
-		return 0x7f;
-	else
-		return 0x0f;
-}
-EXPORT_SYMBOL(tahvo_get_max_backlight_level);
-
-void tahvo_set_backlight_level(int level)
-{
-	struct tahvo		*tahvo = the_tahvo;
-	int			max_level;
-
-	max_level = tahvo_get_max_backlight_level();
-	if (level > max_level)
-		level = max_level;
-	__tahvo_write_reg(tahvo, TAHVO_REG_LEDPWMR, level);
-}
-EXPORT_SYMBOL(tahvo_set_backlight_level);
-
 static irqreturn_t tahvo_irq_handler(int irq, void *_tahvo)
 {
 	struct tahvo		*tahvo = _tahvo;
@@ -379,20 +342,8 @@ static int __devinit tahvo_probe(struct platform_device *pdev)
 
 	id = (rev >> 8) & 0xff;
 
-	switch (id) {
-	case 0x03:
-		if ((rev & 0xff) >= 0x50)
-			tahvo->wide_backlight = true;
-		break;
-	case 0x0b:
+	if (id == 0x0b)
 		tahvo->is_betty = true;
-		tahvo->wide_backlight = true;
-		break;
-	default:
-		dev_err(&pdev->dev, "Tahvo/Betty chip not found");
-		ret = -ENODEV;
-		goto err2;
-	}
 
 	ret = tahvo_allocate_children(&pdev->dev, tahvo->irq_base);
 	if (ret < 0) {
diff --git a/drivers/cbus/tahvo.h b/drivers/cbus/tahvo.h
index 1281710..f151a43 100644
--- a/drivers/cbus/tahvo.h
+++ b/drivers/cbus/tahvo.h
@@ -54,8 +54,5 @@ int tahvo_read_reg(struct device *child, unsigned reg);
 void tahvo_write_reg(struct device *child, unsigned reg, u16 val);
 void tahvo_set_clear_reg_bits(struct device *child, unsigned reg, u16 set,
 		u16 clear);
-int tahvo_get_backlight_level(void);
-int tahvo_get_max_backlight_level(void);
-void tahvo_set_backlight_level(int level);
 
 #endif /* __DRIVERS_CBUS_TAHVO_H */
-- 
1.7.6


  parent reply	other threads:[~2011-07-11 11:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11 11:17 [PATCH 00/22] Tahvo cleanups and Retu optimization Felipe Balbi
2011-07-11 11:17 ` [PATCH 01/22] cbus: tahvo: convert spinlock into mutex Felipe Balbi
2011-07-11 11:17 ` [PATCH 02/22] cbus: tahvo: move to __devinit/__devexit sections Felipe Balbi
2011-07-11 11:17 ` [PATCH 03/22] cbus: tahvo: a switch looks better Felipe Balbi
2011-07-11 11:17 ` [PATCH 04/22] cbus: tahvo: don't go over 80 columns Felipe Balbi
2011-07-11 11:17 ` [PATCH 05/22] cbus: tahvo: drop the tasklet Felipe Balbi
2011-07-11 11:17 ` [PATCH 06/22] cbus: retu: set IRQF_ONESHOT flag Felipe Balbi
2011-07-11 11:17 ` [PATCH 07/22] cbus: tahvo: git it a context structure Felipe Balbi
2011-07-11 11:17 ` [PATCH 08/22] cbus: tahvo: pass tahvo to IRQ handler Felipe Balbi
2011-07-11 11:17 ` [PATCH 09/22] cbus: tahvo: introduce __tahvo_(read/write)_reg Felipe Balbi
2011-07-11 11:17 ` [PATCH 10/22] cbus: tahvo: drop some unneded defines Felipe Balbi
2011-07-11 11:17 ` [PATCH 11/22] cbus: retu: IRQ demux optimization Felipe Balbi
2011-07-11 11:17 ` [PATCH 12/22] cbus: tahvo: give it an irq_chip Felipe Balbi
2011-07-11 11:17 ` [PATCH 13/22] cbus: tahvo: start using irq_chip Felipe Balbi
2011-07-11 11:17 ` [PATCH 14/22] cbus: tahvo: usb: fix up to use threaded irqs Felipe Balbi
2011-07-11 11:17 ` [PATCH 15/22] cbus: tahvo drop the legacy interfaces Felipe Balbi
2011-07-11 11:17 ` [PATCH 16/22] cbus: tahvo: usb: drop unused variable Felipe Balbi
2011-07-11 11:17 ` [PATCH 17/22] cbus: tahvo: no need to mask interrupts on exit Felipe Balbi
2011-07-11 11:17 ` [PATCH 18/22] cbus: tahvo: drop the get_status hack Felipe Balbi
2011-07-11 11:17 ` [PATCH 19/22] cbus: tahvo: drop more unused interfaces Felipe Balbi
2011-07-11 11:17 ` [PATCH 20/22] cbus: tahvo: pass child device pointer Felipe Balbi
2011-07-11 11:17 ` Felipe Balbi [this message]
2011-07-11 11:17 ` [PATCH 22/22] cbus: tahvo: drop static global pointer Felipe Balbi
2011-07-11 11:28 ` [PATCH 00/22] Tahvo cleanups and Retu optimization Michael Büsch
2011-07-11 13:12   ` Felipe Balbi
2011-07-11 13:41     ` Michael Büsch
2011-07-11 13:45       ` Felipe Balbi
2011-07-11 13:51         ` Michael Büsch
2011-07-11 14:03           ` Felipe Balbi
2011-07-11 14:19             ` Michael Büsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310383055-20211-22-git-send-email-balbi@ti.com \
    --to=balbi@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=mb@bu3sch.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox