From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: [PATCH 03/22] cbus: tahvo: a switch looks better Date: Mon, 11 Jul 2011 14:17:16 +0300 Message-ID: <1310383055-20211-4-git-send-email-balbi@ti.com> References: <1310383055-20211-1-git-send-email-balbi@ti.com> Return-path: Received: from na3sys009aog124.obsmtp.com ([74.125.149.151]:36606 "EHLO na3sys009aog124.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754826Ab1GKLSA (ORCPT ); Mon, 11 Jul 2011 07:18:00 -0400 Received: by ywa6 with SMTP id 6so1925075ywa.23 for ; Mon, 11 Jul 2011 04:17:59 -0700 (PDT) In-Reply-To: <1310383055-20211-1-git-send-email-balbi@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: Linux OMAP Mailing List , =?UTF-8?q?Michael=20B=C3=BCsch?= , Felipe Balbi cleanup only, no functional changes. Signed-off-by: Felipe Balbi --- drivers/cbus/tahvo.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c index 0da156e..647d263 100644 --- a/drivers/cbus/tahvo.c +++ b/drivers/cbus/tahvo.c @@ -284,13 +284,17 @@ static int __devinit tahvo_probe(struct platform_device *pdev) rev = tahvo_read_reg(TAHVO_REG_ASICR); id = (rev >> 8) & 0xff; - if (id == 0x03) { + + switch (id) { + case 0x03: if ((rev & 0xff) >= 0x50) tahvo_7bit_backlight = 1; - } else if (id == 0x0b) { + break; + case 0x0b: tahvo_is_betty = 1; tahvo_7bit_backlight = 1; - } else { + break; + default: dev_err(&pdev->dev, "Tahvo/Betty chip not found"); return -ENODEV; } -- 1.7.6