* [PATCH] OMAP: ctrl: Fix CONTROL_DSIPHY register fields @ 2011-07-27 6:20 Archit Taneja 2011-07-27 6:21 ` Santosh Shilimkar 0 siblings, 1 reply; 3+ messages in thread From: Archit Taneja @ 2011-07-27 6:20 UTC (permalink / raw) To: santosh.shilimkar; +Cc: linux-omap, Archit Taneja Fix the shift and mask macros for DSIx_PPID fields in CONTROL_DSIPHY. The Latest TRM mentions the correct fields in the register. Signed-off-by: Archit Taneja <archit@ti.com> --- .../include/mach/ctrl_module_pad_core_44xx.h | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h index c88420d..8321add 100644 --- a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h +++ b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h @@ -941,10 +941,10 @@ #define OMAP4_DSI2_LANEENABLE_MASK (0x7 << 29) #define OMAP4_DSI1_LANEENABLE_SHIFT 24 #define OMAP4_DSI1_LANEENABLE_MASK (0x1f << 24) -#define OMAP4_DSI1_PIPD_SHIFT 19 -#define OMAP4_DSI1_PIPD_MASK (0x1f << 19) -#define OMAP4_DSI2_PIPD_SHIFT 14 -#define OMAP4_DSI2_PIPD_MASK (0x1f << 14) +#define OMAP4_DSI1_PIPD_SHIFT 14 +#define OMAP4_DSI1_PIPD_MASK (0x1f << 14) +#define OMAP4_DSI2_PIPD_SHIFT 19 +#define OMAP4_DSI2_PIPD_MASK (0x1f << 19) /* CONTROL_MCBSPLP */ #define OMAP4_ALBCTRLRX_FSX_SHIFT 31 -- 1.7.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] OMAP: ctrl: Fix CONTROL_DSIPHY register fields 2011-07-27 6:20 [PATCH] OMAP: ctrl: Fix CONTROL_DSIPHY register fields Archit Taneja @ 2011-07-27 6:21 ` Santosh Shilimkar 2011-07-27 9:06 ` Cousson, Benoit 0 siblings, 1 reply; 3+ messages in thread From: Santosh Shilimkar @ 2011-07-27 6:21 UTC (permalink / raw) To: Archit Taneja; +Cc: linux-omap, Benoit Cousson + Benoit On 7/27/2011 11:50 AM, Archit Taneja wrote: > Fix the shift and mask macros for DSIx_PPID fields in CONTROL_DSIPHY. The Latest > TRM mentions the correct fields in the register. You can mention the TRM version instead of 'latest' Latest is very much relative :) > > Signed-off-by: Archit Taneja<archit@ti.com> Change looks good to me. Autogen scripts needs to be checked as well. > --- > .../include/mach/ctrl_module_pad_core_44xx.h | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h > index c88420d..8321add 100644 > --- a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h > +++ b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h > @@ -941,10 +941,10 @@ > #define OMAP4_DSI2_LANEENABLE_MASK (0x7<< 29) > #define OMAP4_DSI1_LANEENABLE_SHIFT 24 > #define OMAP4_DSI1_LANEENABLE_MASK (0x1f<< 24) > -#define OMAP4_DSI1_PIPD_SHIFT 19 > -#define OMAP4_DSI1_PIPD_MASK (0x1f<< 19) > -#define OMAP4_DSI2_PIPD_SHIFT 14 > -#define OMAP4_DSI2_PIPD_MASK (0x1f<< 14) > +#define OMAP4_DSI1_PIPD_SHIFT 14 > +#define OMAP4_DSI1_PIPD_MASK (0x1f<< 14) > +#define OMAP4_DSI2_PIPD_SHIFT 19 > +#define OMAP4_DSI2_PIPD_MASK (0x1f<< 19) > > /* CONTROL_MCBSPLP */ > #define OMAP4_ALBCTRLRX_FSX_SHIFT 31 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] OMAP: ctrl: Fix CONTROL_DSIPHY register fields 2011-07-27 6:21 ` Santosh Shilimkar @ 2011-07-27 9:06 ` Cousson, Benoit 0 siblings, 0 replies; 3+ messages in thread From: Cousson, Benoit @ 2011-07-27 9:06 UTC (permalink / raw) To: Shilimkar, Santosh; +Cc: Taneja, Archit, linux-omap@vger.kernel.org On 7/27/2011 8:21 AM, Shilimkar, Santosh wrote: > + Benoit Thanks Santosh, Archit, Could you please send your patch to all the authors of the file, including the maintainers? Without Santosh, I would have missed that one, that seems to highlight a bug in the HW description DB. So it is quite critical to capture such issue ASAP with HW designers. > On 7/27/2011 11:50 AM, Archit Taneja wrote: >> Fix the shift and mask macros for DSIx_PPID fields in CONTROL_DSIPHY. The Latest >> TRM mentions the correct fields in the register. > You can mention the TRM version instead of 'latest' > Latest is very much relative :) > >> >> Signed-off-by: Archit Taneja<archit@ti.com> > Change looks good to me. > Autogen scripts needs to be checked as well. > >> --- >> .../include/mach/ctrl_module_pad_core_44xx.h | 8 ++++---- >> 1 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h >> index c88420d..8321add 100644 >> --- a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h >> +++ b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h >> @@ -941,10 +941,10 @@ >> #define OMAP4_DSI2_LANEENABLE_MASK (0x7<< 29) >> #define OMAP4_DSI1_LANEENABLE_SHIFT 24 >> #define OMAP4_DSI1_LANEENABLE_MASK (0x1f<< 24) >> -#define OMAP4_DSI1_PIPD_SHIFT 19 >> -#define OMAP4_DSI1_PIPD_MASK (0x1f<< 19) >> -#define OMAP4_DSI2_PIPD_SHIFT 14 >> -#define OMAP4_DSI2_PIPD_MASK (0x1f<< 14) >> +#define OMAP4_DSI1_PIPD_SHIFT 14 >> +#define OMAP4_DSI1_PIPD_MASK (0x1f<< 14) >> +#define OMAP4_DSI2_PIPD_SHIFT 19 >> +#define OMAP4_DSI2_PIPD_MASK (0x1f<< 19) Minor comment, but since this is sorted per shift value, the order should be: +#define OMAP4_DSI2_PIPD_SHIFT 19 +#define OMAP4_DSI2_PIPD_MASK (0x1f << 19) +#define OMAP4_DSI1_PIPD_SHIFT 14 +#define OMAP4_DSI1_PIPD_MASK (0x1f << 14) Once you fix the changelog with Santosh comment, put the proper people in the TO list, and fix the order, you can add: Acked-by: Benoit Cousson <b-cousson@ti.com> Regards, Benoit ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-27 9:06 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-07-27 6:20 [PATCH] OMAP: ctrl: Fix CONTROL_DSIPHY register fields Archit Taneja 2011-07-27 6:21 ` Santosh Shilimkar 2011-07-27 9:06 ` Cousson, Benoit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).