From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Arve Hjønnevåg" <arve@android.com>
Cc: linux-omap@vger.kernel.org, Dima Zavin <dima@android.com>
Subject: Re: [PATCH] OMAP: DSS2: DSI: Support non-dcs long read
Date: Thu, 04 Aug 2011 15:06:51 +0300 [thread overview]
Message-ID: <1312459611.2143.18.camel@deskari> (raw)
In-Reply-To: <1309405483-6876-1-git-send-email-arve@android.com>
Hi,
On Wed, 2011-06-29 at 20:44 -0700, Arve Hjønnevåg wrote:
> Change-Id: I18168c887e1384c07dc033a1ffc57abdacb26073
> Signed-off-by: Arve Hjønnevåg <arve@android.com>
> ---
> drivers/video/omap2/dss/dsi.c | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
This feels somehow partial... Why do you want to read generic packets if
there are no functions to send generic packets?
And always write a patch description.
Tomi
>
> diff --git a/drivers/video/omap2/dss/dsi.c b/drivers/video/omap2/dss/dsi.c
> index c16b933..6975645 100644
> --- a/drivers/video/omap2/dss/dsi.c
> +++ b/drivers/video/omap2/dss/dsi.c
> @@ -206,6 +206,7 @@ struct dsi_reg { u16 idx; };
> #define DSI_DT_DCS_LONG_WRITE 0x39
>
> #define DSI_DT_RX_ACK_WITH_ERR 0x02
> +#define DSI_DT_RX_LONG_READ 0x1a
> #define DSI_DT_RX_DCS_LONG_READ 0x1c
> #define DSI_DT_RX_SHORT_READ_1 0x21
> #define DSI_DT_RX_SHORT_READ_2 0x22
> @@ -2943,6 +2944,10 @@ static u16 dsi_vc_flush_receive_data(struct platform_device *dsidev,
> } else if (dt == DSI_DT_RX_SHORT_READ_2) {
> DSSERR("\tDCS short response, 2 byte: %#x\n",
> FLD_GET(val, 23, 8));
> + } else if (dt == DSI_DT_RX_LONG_READ) {
> + DSSERR("\tlong response, len %d\n",
> + FLD_GET(val, 23, 8));
> + dsi_vc_flush_long_data(dsidev, channel);
> } else if (dt == DSI_DT_RX_DCS_LONG_READ) {
> DSSERR("\tDCS long response, len %d\n",
> FLD_GET(val, 23, 8));
> @@ -3287,7 +3292,7 @@ int dsi_vc_dcs_read(struct omap_dss_device *dssdev, int channel, u8 dcs_cmd,
> buf[1] = (data >> 8) & 0xff;
>
> return 2;
> - } else if (dt == DSI_DT_RX_DCS_LONG_READ) {
> + } else if (dt == DSI_DT_RX_DCS_LONG_READ || dt == DSI_DT_RX_LONG_READ) {
> int w;
> int len = FLD_GET(val, 23, 8);
> if (dsi->debug_read)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-08-04 12:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 3:44 [PATCH] OMAP: DSS2: DSI: Support non-dcs long read Arve Hjønnevåg
2011-08-04 12:06 ` Tomi Valkeinen [this message]
2011-08-05 1:15 ` Arve Hjønnevåg
2011-08-05 7:09 ` Tomi Valkeinen
2011-08-05 7:17 ` Arve Hjønnevåg
2011-08-05 7:53 ` Tomi Valkeinen
2011-08-05 23:05 ` Arve Hjønnevåg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312459611.2143.18.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=arve@android.com \
--cc=dima@android.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox