Re: [PATCH] OMAP: DSS2: DSI: Support non-dcs long read

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

On Thu, 2011-08-04 at 18:15 -0700, Arve Hjønnevåg wrote:
> 2011/8/4 Tomi Valkeinen <tomi.valkeinen@ti.com>:
> > Hi,
> >
> > On Wed, 2011-06-29 at 20:44 -0700, Arve Hjønnevåg wrote:
> >> Change-Id: I18168c887e1384c07dc033a1ffc57abdacb26073
> >> Signed-off-by: Arve Hjønnevåg <arve@android.com>
> >> ---
> >>  drivers/video/omap2/dss/dsi.c |    7 ++++++-
> >>  1 files changed, 6 insertions(+), 1 deletions(-)
> >
> > This feels somehow partial... Why do you want to read generic packets if
> > there are no functions to send generic packets?
> >
> 
> The chip responds with a generic packet when reading from some
> registers. This is a simple fix while adding support for sending
> generic packets would probably require an api change.

What command do you use to read the register? DCS? If so, sounds rather
strange HW implementation.

If you use generic commands, for which you have support in your kernel,
I think it's better to add both write and read support at the same time.
Adding just read support, without any way to actually use the read,
doesn't sound sensible.

 Tomi


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html