Re: [PATCH 5/5] OMAP4: DSS2: VIDEO3 pipeline support

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

On Fri, 2011-08-05 at 14:51 +0530, Archit Taneja wrote:
> Hi,
> 
> On Friday 05 August 2011 02:13 PM, Semwal, Sumit wrote:
> >> On Fri, Aug 5, 2011 at 8:42 AM, Archit Taneja<archit@ti.com>  wrote:
> >>>
> >>> Add support for VIDEO3 pipeline on OMAP4:
> >>> - Add VIDEO3 pipeline information in dss_features and omapdss.h
> >>> - Add VIDEO3 pipeline register coefficients in dispc.h
> >>> - Create a new overlay structure corresponding to VIDEO3.
> >>>
> >>> Signed-off-by: Archit Taneja<archit@ti.com>
> >>> ---
> > <snip>
> >>> -       u32     fifo_size[3];
> >>> +       u32     fifo_size[MAX_DSS_OVERLAYS];
> >>
> > Do you think it makes some sense in splitting the 'generalisation'
> > like this that you've done in the patch from the xxx_VIDEO3 changes?
> 
> Yes, I could make a small patch which replaces "3" with 
> MAX_DSS_OVERLAYS, and the patch which introduces VIDEO3 pipe will 
> increase the macro value from 3 to 4.

While Sumit is right, I don't think that's worth the effort if it's just
about this single line.

I think this patch set looks fine. At least the register dump works just
the way I like it. I didn't test the vid3 yet, though.

 Tomi