From: Kyle Manna <kyle@kylemanna.com>
To: linux-omap@vger.kernel.org
Cc: Kyle Manna <kyle@kylemanna.com>
Subject: [PATCH 1/3] twl4030-madc: copy the device pointer
Date: Wed, 10 Aug 2011 22:27:50 -0500 [thread overview]
Message-ID: <1313033272-16774-2-git-send-email-kyle@kylemanna.com> (raw)
In-Reply-To: <1313033272-16774-1-git-send-email-kyle@kylemanna.com>
Worst case this fixes the following error:
[ 72.086212] (NULL device *): conversion timeout!
Best case it prevents a crash
Signed-off-by: Kyle Manna <kyle@kylemanna.com>
---
drivers/mfd/twl4030-madc.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/twl4030-madc.c b/drivers/mfd/twl4030-madc.c
index b5d598c..8ef7801 100644
--- a/drivers/mfd/twl4030-madc.c
+++ b/drivers/mfd/twl4030-madc.c
@@ -706,6 +706,9 @@ static int __devinit twl4030_madc_probe(struct platform_device *pdev)
if (!madc)
return -ENOMEM;
+ /* Copy the pointer to device struct */
+ madc->dev = &pdev->dev;
+
/*
* Phoenix provides 2 interrupt lines. The first one is connected to
* the OMAP. The other one can be connected to the other processor such
@@ -733,7 +736,7 @@ static int __devinit twl4030_madc_probe(struct platform_device *pdev)
ret = twl_i2c_write_u8(TWL4030_MODULE_MAIN_CHARGE,
regval, TWL4030_BCI_BCICTL1);
if (ret) {
- dev_err(&pdev->dev, "unable to write reg BCI Ctl1 0x%X\n",
+ dev_err(&pdev->dev, "unable to write reg BCI CTL1 0x%X\n",
TWL4030_BCI_BCICTL1);
goto err_i2c;
}
--
1.7.4.1
next prev parent reply other threads:[~2011-08-11 3:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 3:27 [PATCH 0/3] Fixes to twl4030-madc and add BeagleBoard support Kyle Manna
2011-08-11 3:27 ` Kyle Manna [this message]
2011-08-11 9:50 ` [PATCH 1/3] twl4030-madc: copy the device pointer Grazvydas Ignotas
2011-08-11 3:27 ` [PATCH 2/3] twl4030-madc: turn on the MADC clock Kyle Manna
2011-08-11 9:55 ` Grazvydas Ignotas
2011-08-11 3:27 ` [PATCH 3/3] BeagleBoard: add support for the twl4030-madc Kyle Manna
2011-08-11 9:44 ` Grazvydas Ignotas
2011-08-12 3:33 ` [PATCH v2 0/4] Fixes to twl4030-madc and add BeagleBoard support Kyle Manna
2011-08-12 3:33 ` [PATCH v2 1/4] mfd: twl4030-madc: copy the device pointer Kyle Manna
2011-08-12 3:33 ` [PATCH v2 2/4] mfd: twl4030-madc: turn on the MADC clock Kyle Manna
2011-08-12 3:33 ` [PATCH v2 3/4] mfd: twl4030-madc: check for NULL pointer Kyle Manna
2011-08-12 3:33 ` [PATCH v2 4/4] arm: BeagleBoard: add support for the twl4030-madc Kyle Manna
2011-09-28 18:31 ` Tony Lindgren
2011-08-22 13:55 ` [PATCH v2 0/4] Fixes to twl4030-madc and add BeagleBoard support Samuel Ortiz
2011-09-28 18:32 ` Tony Lindgren
2011-10-04 10:28 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313033272-16774-2-git-send-email-kyle@kylemanna.com \
--to=kyle@kylemanna.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).