* [PATCH] Media controller: Define media_entity_init() and media_entity_cleanup() conditionally @ 2011-08-17 10:34 Deepthy Ravi 2011-08-17 10:53 ` Andy Shevchenko 2011-08-17 15:30 ` Hiremath, Vaibhav 0 siblings, 2 replies; 5+ messages in thread From: Deepthy Ravi @ 2011-08-17 10:34 UTC (permalink / raw) To: mchehab, linux-media, linux-kernel Cc: linux-omap, Vaibhav Hiremath, Deepthy Ravi From: Vaibhav Hiremath <hvaibhav@ti.com> Defines the two functions only when CONFIG_MEDIA_CONTROLLER is enabled. Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> Signed-off-by: Deepthy Ravi <deepthy.ravi@ti.com> --- include/media/media-entity.h | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/include/media/media-entity.h b/include/media/media-entity.h index cd8bca6..c90916e 100644 --- a/include/media/media-entity.h +++ b/include/media/media-entity.h @@ -121,9 +121,18 @@ struct media_entity_graph { int top; }; +#ifdef CONFIG_MEDIA_CONTROLLER int media_entity_init(struct media_entity *entity, u16 num_pads, struct media_pad *pads, u16 extra_links); void media_entity_cleanup(struct media_entity *entity); +#else +static inline int media_entity_init(struct media_entity *entity, u16 num_pads, + struct media_pad *pads, u16 extra_links) +{ + return 0; +} +static inline void media_entity_cleanup(struct media_entity *entity) {} +#endif int media_entity_create_link(struct media_entity *source, u16 source_pad, struct media_entity *sink, u16 sink_pad, u32 flags); -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Media controller: Define media_entity_init() and media_entity_cleanup() conditionally 2011-08-17 10:34 [PATCH] Media controller: Define media_entity_init() and media_entity_cleanup() conditionally Deepthy Ravi @ 2011-08-17 10:53 ` Andy Shevchenko 2011-08-18 9:03 ` Laurent Pinchart 2011-08-17 15:30 ` Hiremath, Vaibhav 1 sibling, 1 reply; 5+ messages in thread From: Andy Shevchenko @ 2011-08-17 10:53 UTC (permalink / raw) To: Deepthy Ravi Cc: mchehab, linux-media, linux-kernel, linux-omap, Vaibhav Hiremath On Wed, 2011-08-17 at 16:04 +0530, Deepthy Ravi wrote: > From: Vaibhav Hiremath <hvaibhav@ti.com> > > Defines the two functions only when CONFIG_MEDIA_CONTROLLER > is enabled. Is it not a driver's option to be dependent on MEDIA_CONTROLLER? -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Media controller: Define media_entity_init() and media_entity_cleanup() conditionally 2011-08-17 10:53 ` Andy Shevchenko @ 2011-08-18 9:03 ` Laurent Pinchart 0 siblings, 0 replies; 5+ messages in thread From: Laurent Pinchart @ 2011-08-18 9:03 UTC (permalink / raw) To: Andy Shevchenko Cc: Deepthy Ravi, mchehab, linux-media, linux-kernel, linux-omap, Vaibhav Hiremath On Wednesday 17 August 2011 12:53:46 Andy Shevchenko wrote: > On Wed, 2011-08-17 at 16:04 +0530, Deepthy Ravi wrote: > > From: Vaibhav Hiremath <hvaibhav@ti.com> > > > > Defines the two functions only when CONFIG_MEDIA_CONTROLLER > > is enabled. > > Is it not a driver's option to be dependent on MEDIA_CONTROLLER? Yes it is. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] Media controller: Define media_entity_init() and media_entity_cleanup() conditionally 2011-08-17 10:34 [PATCH] Media controller: Define media_entity_init() and media_entity_cleanup() conditionally Deepthy Ravi 2011-08-17 10:53 ` Andy Shevchenko @ 2011-08-17 15:30 ` Hiremath, Vaibhav 2011-08-18 10:09 ` Ravi, Deepthy 1 sibling, 1 reply; 5+ messages in thread From: Hiremath, Vaibhav @ 2011-08-17 15:30 UTC (permalink / raw) To: Ravi, Deepthy, mchehab@infradead.org, linux-media@vger.kernel.org Cc: linux-omap@vger.kernel.org > -----Original Message----- > From: Ravi, Deepthy > Sent: Wednesday, August 17, 2011 4:05 PM > To: mchehab@infradead.org; linux-media@vger.kernel.org; linux- > kernel@vger.kernel.org > Cc: linux-omap@vger.kernel.org; Hiremath, Vaibhav; Ravi, Deepthy > Subject: [PATCH] Media controller: Define media_entity_init() and > media_entity_cleanup() conditionally > > From: Vaibhav Hiremath <hvaibhav@ti.com> > > Defines the two functions only when CONFIG_MEDIA_CONTROLLER > is enabled. [Hiremath, Vaibhav] Deepthy, You may want to mention about build failure without MEDIA_CONTROLLER option being enabled, especially if any sensor driver is being used between MC and non-MC framework compatible devices. For example, OMAP3 and AM3517, where TVP5146 is being used but OMAP3 is based on MC framework and AM3517 is based on simple sub-dev based interface. Thanks, Vaibhav > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> > Signed-off-by: Deepthy Ravi <deepthy.ravi@ti.com> > --- > include/media/media-entity.h | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/include/media/media-entity.h b/include/media/media-entity.h > index cd8bca6..c90916e 100644 > --- a/include/media/media-entity.h > +++ b/include/media/media-entity.h > @@ -121,9 +121,18 @@ struct media_entity_graph { > int top; > }; > > +#ifdef CONFIG_MEDIA_CONTROLLER > int media_entity_init(struct media_entity *entity, u16 num_pads, > struct media_pad *pads, u16 extra_links); > void media_entity_cleanup(struct media_entity *entity); > +#else > +static inline int media_entity_init(struct media_entity *entity, u16 > num_pads, > + struct media_pad *pads, u16 extra_links) > +{ > + return 0; > +} > +static inline void media_entity_cleanup(struct media_entity *entity) {} > +#endif > > int media_entity_create_link(struct media_entity *source, u16 source_pad, > struct media_entity *sink, u16 sink_pad, u32 flags); > -- > 1.7.0.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] Media controller: Define media_entity_init() and media_entity_cleanup() conditionally 2011-08-17 15:30 ` Hiremath, Vaibhav @ 2011-08-18 10:09 ` Ravi, Deepthy 0 siblings, 0 replies; 5+ messages in thread From: Ravi, Deepthy @ 2011-08-18 10:09 UTC (permalink / raw) To: Hiremath, Vaibhav, mchehab@infradead.org, linux-media@vger.kernel.org Cc: linux-omap@vger.kernel.org Thanks, Deepthy Ravi. ________________________________________ From: Hiremath, Vaibhav Sent: Wednesday, August 17, 2011 9:00 PM To: Ravi, Deepthy; mchehab@infradead.org; linux-media@vger.kernel.org; linux-kernel@vger.kernel.org Cc: linux-omap@vger.kernel.org Subject: RE: [PATCH] Media controller: Define media_entity_init() and media_entity_cleanup() conditionally > -----Original Message----- > From: Ravi, Deepthy > Sent: Wednesday, August 17, 2011 4:05 PM > To: mchehab@infradead.org; linux-media@vger.kernel.org; linux- > kernel@vger.kernel.org > Cc: linux-omap@vger.kernel.org; Hiremath, Vaibhav; Ravi, Deepthy > Subject: [PATCH] Media controller: Define media_entity_init() and > media_entity_cleanup() conditionally > > From: Vaibhav Hiremath <hvaibhav@ti.com> > > Defines the two functions only when CONFIG_MEDIA_CONTROLLER > is enabled. [Hiremath, Vaibhav] Deepthy, You may want to mention about build failure without MEDIA_CONTROLLER option being enabled, especially if any sensor driver is being used between MC and non-MC framework compatible devices. For example, OMAP3 and AM3517, where TVP5146 is being used but OMAP3 is based on MC framework and AM3517 is based on simple sub-dev based interface. [Deepthy Ravi] Ok. I will change description to include that. Thanks, Vaibhav > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> > Signed-off-by: Deepthy Ravi <deepthy.ravi@ti.com> > --- > include/media/media-entity.h | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/include/media/media-entity.h b/include/media/media-entity.h > index cd8bca6..c90916e 100644 > --- a/include/media/media-entity.h > +++ b/include/media/media-entity.h > @@ -121,9 +121,18 @@ struct media_entity_graph { > int top; > }; > > +#ifdef CONFIG_MEDIA_CONTROLLER > int media_entity_init(struct media_entity *entity, u16 num_pads, > struct media_pad *pads, u16 extra_links); > void media_entity_cleanup(struct media_entity *entity); > +#else > +static inline int media_entity_init(struct media_entity *entity, u16 > num_pads, > + struct media_pad *pads, u16 extra_links) > +{ > + return 0; > +} > +static inline void media_entity_cleanup(struct media_entity *entity) {} > +#endif > > int media_entity_create_link(struct media_entity *source, u16 source_pad, > struct media_entity *sink, u16 sink_pad, u32 flags); > -- > 1.7.0.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-18 10:09 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-08-17 10:34 [PATCH] Media controller: Define media_entity_init() and media_entity_cleanup() conditionally Deepthy Ravi 2011-08-17 10:53 ` Andy Shevchenko 2011-08-18 9:03 ` Laurent Pinchart 2011-08-17 15:30 ` Hiremath, Vaibhav 2011-08-18 10:09 ` Ravi, Deepthy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox