From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: paul@pwsan.com
Cc: linux-omap@vger.kernel.org, b-cousson@ti.com, archit@ti.com
Subject: Re: [PATCHv2 0/5] OMAP DSS HWMOD fixes
Date: Thu, 18 Aug 2011 10:21:55 +0300 [thread overview]
Message-ID: <1313652115.1782.17.camel@deskari> (raw)
In-Reply-To: <1312794914-22894-1-git-send-email-tomi.valkeinen@ti.com>
Hi Paul,
Did you get a chance to look at this series? These fixes will allow us
to remove the temporary hacks from the DSS driver.
Tomi
On Mon, 2011-08-08 at 12:15 +0300, Tomi Valkeinen wrote:
> Second try with the DSS HWMODs
>
> This set fixes the DSS clocks in HWMOD data, and implements a new reset
> mechanism for dss_core.
>
> The new dss_reset function doesn't actually do a reset, it just enables all DSS
> clocks and waits for the reset to complete. This should be better approach than
> actually doing a reset, because:
>
> OMAP4 - dss_core HW doesn't contain a SW reset bit so doing a reset is
> impossible. But after power-on we need to enable all DSS clocks and wait for
> the power-on reset to complete.
>
> OMAP2/3 - dss_core does have a SW reset bit, but resetting dss_core also resets
> all the other DSS modules. This means that the other modules could be left
> uninitialized, as the hwmod code handles all modules independently, and in this
> case initializes only dss_core's registers. Thus dss_core's reset shouldn't be
> used, and we should only verify that the power-on reset has completed.
>
> Tested on OMAP4 and OMAP3.
>
> The first two HWMOD patches (for OMAP2/3) are not changed since v1.
>
> Tomi
>
> Tomi Valkeinen (5):
> OMAP2xxx: HWMOD: fix DSS opt clocks
> OMAP3: HWMOD: fix DSS opt clocks
> OMAP4: HWMOD: fix DSS opt clocks
> OMAP2/3: HWMOD: Add SYSS_HAS_RESET_STATUS for dss
> OMAP: HWMOD: Unify DSS resets for all OMAPs
>
> arch/arm/mach-omap2/common-board-devices.h | 4 ++
> arch/arm/mach-omap2/display.c | 35 ++++++++++++++++++++
> arch/arm/mach-omap2/omap_hwmod_2420_data.c | 15 +++++++-
> arch/arm/mach-omap2/omap_hwmod_2430_data.c | 15 +++++++-
> .../mach-omap2/omap_hwmod_2xxx_3xxx_ipblock_data.c | 5 ++-
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 35 +++++++++++++++++--
> arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 18 +++-------
> 7 files changed, 106 insertions(+), 21 deletions(-)
>
next prev parent reply other threads:[~2011-08-18 7:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 9:15 [PATCHv2 0/5] OMAP DSS HWMOD fixes Tomi Valkeinen
2011-08-08 9:15 ` [PATCHv2 1/5] OMAP2xxx: HWMOD: fix DSS opt clocks Tomi Valkeinen
2011-08-08 9:15 ` [PATCHv2 2/5] OMAP3: " Tomi Valkeinen
2011-08-08 9:15 ` [PATCHv2 3/5] OMAP4: " Tomi Valkeinen
2011-08-09 16:17 ` Cousson, Benoit
2011-08-08 9:15 ` [PATCHv2 4/5] OMAP2/3: HWMOD: Add SYSS_HAS_RESET_STATUS for dss Tomi Valkeinen
2011-08-08 9:15 ` [PATCHv2 5/5] OMAP: HWMOD: Unify DSS resets for all OMAPs Tomi Valkeinen
2011-08-20 5:30 ` Paul Walmsley
2011-08-20 6:26 ` Paul Walmsley
2011-08-22 7:00 ` Tomi Valkeinen
2011-08-22 19:10 ` Paul Walmsley
2011-08-08 11:43 ` [PATCHv2 0/5] OMAP DSS HWMOD fixes Archit Taneja
2011-08-08 12:03 ` Tomi Valkeinen
2011-08-08 12:21 ` Archit Taneja
2011-08-08 12:23 ` Tomi Valkeinen
2011-08-18 7:21 ` Tomi Valkeinen [this message]
2011-08-21 6:03 ` Paul Walmsley
2011-08-22 6:35 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313652115.1782.17.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=archit@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox