public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Bryan DE FARIA <bdefaria@adeneo-embedded.com>
To: "Gupta, Ajay Kumar" <ajay.gupta@ti.com>
Cc: "tony@atomide.com" <tony@atomide.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"grinberg@compulab.co.il" <grinberg@compulab.co.il>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v2] OMAP3EVM: ehci: Fix EHCI support
Date: Wed, 24 Aug 2011 14:42:07 +0200	[thread overview]
Message-ID: <1314189727.2320.16.camel@bryan-HUTIA> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E739404EC007BC0@dbde02.ent.ti.com>

Hi Ajay,

TPS65950 GPIO2 is to choose through u131 if we drive the lines to the
evm mother board or to the expansion connector p18. Should not it be
default to the mother board?
The EHCI port on the mother board works with this patch.

Bryan

> Hi,
> > Set the VAUX2 regulator supply to 1.8V for the HSUSB host interface.
> > Gpio 2 of the TPS65950 has to be set to zero in order to enable the
> > HSUBS2 clock.
> 
> TPS65950 GPIO2 is not to enable HSUSB2 clock but to enable chip u131
> On omap3evm (rev-G) which latches USB, camera and audio lines.
> 
> > 
> > Signed-off-by: Bryan DE FARIA <bdefaria@adeneo-embedded.com>
> > ---
> >  arch/arm/mach-omap2/board-omap3evm.c |   25 +++++++++++++++++++++++++
> >  1 files changed, 25 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-
> > omap2/board-omap3evm.c
> > index c452b3f..13a2b71 100644
> > --- a/arch/arm/mach-omap2/board-omap3evm.c
> > +++ b/arch/arm/mach-omap2/board-omap3evm.c
> > @@ -377,6 +377,10 @@ static int omap3evm_twl_gpio_setup(struct device
> > *dev,
> >  	if (r)
> >  		printk(KERN_ERR "failed to get/set lcd_bkl gpio\n");
> > 
> > +	/* gpio + 2 == HSUSB2 Clock Enable */
> > +	if (get_omap3_evm_rev() >= OMAP3EVM_BOARD_GEN_2)
> > +		gpio_request_one(gpio + 2, GPIOF_OUT_INIT_LOW,
> > "EN_HSUSB2_CLK");
> > +
> 
> Did you test EHCI port with this change ?
> 
> Ajay
> >  	/* gpio + 7 == DVI Enable */
> >  	gpio_request_one(gpio + 7, GPIOF_OUT_INIT_LOW, "EN_DVI");
> [...]
> rm-kernel

  reply	other threads:[~2011-08-24 12:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-24  8:35 [PATCH v2] OMAP3EVM: ehci: Fix EHCI support Bryan DE FARIA
2011-08-24 11:53 ` Gupta, Ajay Kumar
2011-08-24 12:42   ` Bryan DE FARIA [this message]
2011-08-24 14:39     ` Gupta, Ajay Kumar
2011-08-24 16:03       ` Bryan DE FARIA
2011-08-24 16:22         ` Gupta, Ajay Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314189727.2320.16.camel@bryan-HUTIA \
    --to=bdefaria@adeneo-embedded.com \
    --cc=ajay.gupta@ti.com \
    --cc=grinberg@compulab.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox