From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <archit@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 10/10] OMAP: DSS2: DSI Video mode support
Date: Thu, 01 Sep 2011 16:14:29 +0300 [thread overview]
Message-ID: <1314882869.2169.22.camel@lappyti> (raw)
In-Reply-To: <1314701495-11247-11-git-send-email-archit@ti.com>
On Tue, 2011-08-30 at 16:21 +0530, Archit Taneja wrote:
> Add initial support for DSI video mode panels:
> - Add a new structure omap_dss_dsi_videomode_data in the member "panel" in
> omap_dss_device struct. This allows panel driver to configure dsi video_mode
> specific parameters.
> - Configure basic DSI video mode timing parameters: HBP, HFP, HSA, VBP, VFP, VSA,
> TL and VACT.
> - Configure DSI protocol engine registers for video_mode support.
> - Introduce functions dsi_video_mode_enable() and dsi_video_mode_disable() which
> enable/disable video mode for a given virtual channel and a given pixel format
> type.
>
> Things left for later
> - Add functions to check for errors in video mode timings provided by panel.
> - Configure timing registers required for command mode interleaving.
>
> Signed-off-by: Archit Taneja <archit@ti.com>
> ---
> drivers/video/omap2/dss/dsi.c | 256 ++++++++++++++++++++++++++++++++++++-----
> include/video/omapdss.h | 32 +++++
> 2 files changed, 259 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/video/omap2/dss/dsi.c b/drivers/video/omap2/dss/dsi.c
> index 582ae7b..e3d5c38 100644
> --- a/drivers/video/omap2/dss/dsi.c
> +++ b/drivers/video/omap2/dss/dsi.c
> @@ -132,7 +132,7 @@ struct dsi_reg { u16 idx; };
> #define DSI_IRQ_TA_TIMEOUT (1 << 20)
> #define DSI_IRQ_ERROR_MASK \
> (DSI_IRQ_HS_TX_TIMEOUT | DSI_IRQ_LP_RX_TIMEOUT | DSI_IRQ_SYNC_LOST | \
> - DSI_IRQ_TA_TIMEOUT)
> + DSI_IRQ_TA_TIMEOUT | DSI_IRQ_SYNC_LOST)
> #define DSI_IRQ_CHANNEL_MASK 0xf
>
> /* Virtual channel interrupts */
> @@ -2472,6 +2472,12 @@ static int dsi_cio_init(struct omap_dss_device *dssdev)
>
> dsi_cio_timings(dsidev);
>
> + if (dssdev->panel.dsi_mode == OMAP_DSS_DSI_VIDEO_MODE) {
> + /* DDR_CLK_ALWAYS_ON */
> + REG_FLD_MOD(dsidev, DSI_CLK_CTRL,
> + dssdev->panel.dsi_vm_data.ddr_clk_always_on, 13, 13);
> + }
> +
For the DDR clock to start, you need to send a null packet, don't you?
Tomi
next prev parent reply other threads:[~2011-09-01 13:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 10:51 [PATCH 00/10] OMAP: DSS2: DSI: Initial DSI video mode support Archit Taneja
2011-08-30 10:51 ` [PATCH 01/10] OMAP: DSS2: Use MIPI DSI transacition types and commands from include/video/mipi_display.h Archit Taneja
2011-08-30 10:51 ` [PATCH 02/10] OMAP: DSS2: DSI: Represent L4 and VP as sources of VC instead of modes Archit Taneja
2011-08-30 10:51 ` [PATCH 03/10] OMAP: DSS2: Create enum for DSI operation modes Archit Taneja
2011-08-30 10:51 ` [PATCH 04/10] OMAP: DSS2: DSI: Introduce generic write functions Archit Taneja
2011-08-30 10:51 ` [PATCH 05/10] OMAP: DSS2: DSI: Remove functions dsi_vc_dcs_read_1() and dsi_vc_dcs_read_2() Archit Taneja
2011-08-30 10:51 ` [PATCH 06/10] OMAP: DSS2: DSI: Split dsi_vc_dcs_read() into 2 functions Archit Taneja
2011-08-30 10:51 ` [PATCH 07/10] OMAP: DSS2: DSI: Introduce generic read functions Archit Taneja
2011-08-30 10:51 ` [PATCH 08/10] OMAP: DSS2: Clean up stallmode and io pad mode selection Archit Taneja
2011-08-30 10:51 ` [PATCH 09/10] OMAP: DSS2: Create an enum for DSI pixel formats Archit Taneja
2011-08-30 10:51 ` [PATCH 10/10] OMAP: DSS2: DSI Video mode support Archit Taneja
2011-09-01 13:14 ` Tomi Valkeinen [this message]
2011-09-02 5:15 ` Archit Taneja
2011-09-02 5:32 ` Tomi Valkeinen
2011-09-02 6:13 ` Archit Taneja
2011-09-02 7:55 ` Tomi Valkeinen
2011-09-05 5:52 ` Archit Taneja
2011-09-05 6:52 ` Tomi Valkeinen
2011-09-05 7:11 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314882869.2169.22.camel@lappyti \
--to=tomi.valkeinen@ti.com \
--cc=archit@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox