From: Benoit Cousson <b-cousson@ti.com>
To: khilman@ti.com
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Benoit Cousson <b-cousson@ti.com>
Subject: [PATCH v2 4/6] OMAP2+: pm: Remove static devices variable for mpu, dsp, iva and l3 PM
Date: Fri, 2 Sep 2011 16:25:18 +0200 [thread overview]
Message-ID: <1314973520-3585-5-git-send-email-b-cousson@ti.com> (raw)
In-Reply-To: <1314973520-3585-1-git-send-email-b-cousson@ti.com>
Since the device pointer is now retrieved using the hwmod name, remove
the static variables used to store the device pointers for DSP, MPU, IVA
and L3 devices for PM/DVFS usage.
Signed-off-by: Benoit Cousson <b-cousson@ti.com>
Cc: Kevin Hilman <khilman@ti.com>
---
arch/arm/mach-omap2/pm.c | 47 ++++++---------------------------------------
1 files changed, 7 insertions(+), 40 deletions(-)
diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
index 17725d2..832577a 100644
--- a/arch/arm/mach-omap2/pm.c
+++ b/arch/arm/mach-omap2/pm.c
@@ -26,38 +26,7 @@
static struct omap_device_pm_latency *pm_lats;
-static struct device *mpu_dev;
-static struct device *iva_dev;
-static struct device *l3_dev;
-static struct device *dsp_dev;
-
-struct device *omap2_get_mpuss_device(void)
-{
- WARN_ON_ONCE(!mpu_dev);
- return mpu_dev;
-}
-
-struct device *omap2_get_iva_device(void)
-{
- WARN_ON_ONCE(!iva_dev);
- return iva_dev;
-}
-
-struct device *omap2_get_l3_device(void)
-{
- WARN_ON_ONCE(!l3_dev);
- return l3_dev;
-}
-
-struct device *omap4_get_dsp_device(void)
-{
- WARN_ON_ONCE(!dsp_dev);
- return dsp_dev;
-}
-EXPORT_SYMBOL(omap4_get_dsp_device);
-
-/* static int _init_omap_device(struct omap_hwmod *oh, void *user) */
-static int _init_omap_device(char *name, struct device **new_dev)
+static int _init_omap_device(char *name)
{
struct omap_hwmod *oh;
struct platform_device *pdev;
@@ -72,8 +41,6 @@ static int _init_omap_device(char *name, struct device **new_dev)
__func__, name))
return -ENODEV;
- *new_dev = &pdev->dev;
-
return 0;
}
@@ -82,16 +49,16 @@ static int _init_omap_device(char *name, struct device **new_dev)
*/
static void omap2_init_processor_devices(void)
{
- _init_omap_device("mpu", &mpu_dev);
+ _init_omap_device("mpu");
if (omap3_has_iva())
- _init_omap_device("iva", &iva_dev);
+ _init_omap_device("iva");
if (cpu_is_omap44xx()) {
- _init_omap_device("l3_main_1", &l3_dev);
- _init_omap_device("dsp", &dsp_dev);
- _init_omap_device("iva", &iva_dev);
+ _init_omap_device("l3_main_1");
+ _init_omap_device("dsp");
+ _init_omap_device("iva");
} else {
- _init_omap_device("l3_main", &l3_dev);
+ _init_omap_device("l3_main");
}
}
--
1.7.0.4
next prev parent reply other threads:[~2011-09-02 14:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 14:25 [PATCH v2 0/6] OMAP: omap_device cleanup before device-tree integration Benoit Cousson
2011-09-02 14:25 ` [PATCH v2 1/6] OMAP: omap_device: Add omap_hwmod_name_get_dev Benoit Cousson
2011-09-26 18:24 ` Kevin Hilman
2011-09-02 14:25 ` [PATCH v2 2/6] OMAP3: beagle-board: Use the omap_hwmod_name_get_dev API Benoit Cousson
2011-09-02 14:25 ` [PATCH v2 3/6] OMAP2+: pm: Use hwmod name instead of dev pointer Benoit Cousson
2011-09-02 14:25 ` Benoit Cousson [this message]
2011-09-02 14:25 ` [PATCH v2 5/6] OMAP: omap_device: Create a default omap_device_pm_latency Benoit Cousson
2011-09-16 11:52 ` Cousson, Benoit
2011-09-16 16:41 ` Kevin Hilman
2011-09-02 14:25 ` [PATCH v2 6/6] OMAP2+: devices: Remove all omap_device_pm_latency structures Benoit Cousson
2011-09-26 22:36 ` [PATCH v2 0/6] OMAP: omap_device cleanup before device-tree integration Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314973520-3585-5-git-send-email-b-cousson@ti.com \
--to=b-cousson@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox