From: Archit Taneja <archit@ti.com>
To: tomi.valkeinen@ti.com, hvaibhav@ti.com
Cc: linux-omap@vger.kernel.org, Archit Taneja <archit@ti.com>
Subject: [PATCH 08/10] OMAP2PLUS: DSS2: DISPC: Remove hardcoded use of PPL in five tap clock calculation
Date: Wed, 14 Sep 2011 17:55:12 +0530 [thread overview]
Message-ID: <1316003114-24291-5-git-send-email-archit@ti.com> (raw)
In-Reply-To: <1316003114-24291-1-git-send-email-archit@ti.com>
The function calc_fclk_five_taps() uses a fixed value of pixels per line which
is used in calculations to get the minimum fclk needed for scaling with five
taps to work.
Remove this by providing the width of the panel connected to the manager.
Signed-off-by: Archit Taneja <archit@ti.com>
---
drivers/video/omap2/dss/dispc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c
index 1a8a12c..307e70e 100644
--- a/drivers/video/omap2/dss/dispc.c
+++ b/drivers/video/omap2/dss/dispc.c
@@ -1654,8 +1654,8 @@ static unsigned long calc_fclk_five_taps(enum omap_channel channel, u16 width,
u64 tmp, pclk = dispc_mgr_pclk_rate(channel);
if (height > out_height) {
- /* FIXME get real display PPL */
- unsigned int ppl = 800;
+ struct omap_dss_device *dssdev = dispc_mgr_get_device(channel);
+ unsigned int ppl = dssdev->panel.timings.x_res;
tmp = pclk * height * out_width;
do_div(tmp, 2 * out_height * ppl);
--
1.7.1
next prev parent reply other threads:[~2011-09-14 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 12:25 [PATCH v3 04/10] OMAP4: DSS2: VIDEO3 pipeline support Archit Taneja
2011-09-14 12:25 ` [PATCH v3 05/10] OMAP4: DSS2: zorder support for DSS overlays Archit Taneja
2011-09-14 12:25 ` [PATCH v3 06/10] OMAP: DSS2: Create helper function dispc_mgr_is_lcd() Archit Taneja
2011-09-14 12:25 ` [PATCH 07/10] v3 OMAP2PLUS: DSS2: Get correct pixel clock for TV manager Archit Taneja
2011-09-14 12:25 ` Archit Taneja [this message]
2011-09-14 12:25 ` [PATCH 09/10] OMAP2PLUS: DSS2: Clean up DISPC scaling related clock and five tap calculations Archit Taneja
2011-09-14 12:25 ` [PATCH 10/10] OMAP2PLUS: DSS2: FEATURES: Create a range param to get max downscaling Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316003114-24291-5-git-send-email-archit@ti.com \
--to=archit@ti.com \
--cc=hvaibhav@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox