[PATCH v2 3/3] TI814X: Create board support and enable build for TI8148 EVM

[PATCH v2 3/3] TI814X: Create board support and enable build for TI8148 EVM

[Hemant Pedanekar]

This patch adds minimal support and build configuration for TI8148 EVM. Also
adds support for low level debugging on UART1 console on the EVM.

Signed-off-by: Hemant Pedanekar <hemantp@ti.com>
---
 arch/arm/mach-omap2/Kconfig                  |    5 +++
 arch/arm/mach-omap2/Makefile                 |    1 +
 arch/arm/mach-omap2/board-ti8148evm.c        |   51 ++++++++++++++++++++++++++
 arch/arm/plat-omap/include/plat/uncompress.h |    3 ++
 4 files changed, 60 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-omap2/board-ti8148evm.c

diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index a3b9227..cc4f213 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -316,6 +316,11 @@ config MACH_TI8168EVM
 	depends on SOC_OMAPTI81XX
 	default y
 
+config MACH_TI8148EVM
+	bool "TI8148 Evaluation Module"
+	depends on SOC_OMAPTI81XX
+	default y
+
 config MACH_OMAP_4430SDP
 	bool "OMAP 4430 SDP board"
 	default y
diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
index 46a3497..597a2b6 100644
--- a/arch/arm/mach-omap2/Makefile
+++ b/arch/arm/mach-omap2/Makefile
@@ -242,6 +242,7 @@ obj-$(CONFIG_MACH_CRANEBOARD)		+= board-am3517crane.o
 
 obj-$(CONFIG_MACH_SBC3530)		+= board-omap3stalker.o
 obj-$(CONFIG_MACH_TI8168EVM)		+= board-ti8168evm.o
+obj-$(CONFIG_MACH_TI8148EVM)		+= board-ti8148evm.o
 
 # Platform specific device init code
 
diff --git a/arch/arm/mach-omap2/board-ti8148evm.c b/arch/arm/mach-omap2/board-ti8148evm.c
new file mode 100644
index 0000000..355c766
--- /dev/null
+++ b/arch/arm/mach-omap2/board-ti8148evm.c
@@ -0,0 +1,51 @@
+/*
+ * Code for TI8148 EVM.
+ *
+ * Copyright (C) 2010 Texas Instruments, Inc. - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation version 2.
+ *
+ * This program is distributed "as is" WITHOUT ANY WARRANTY of any
+ * kind, whether express or implied; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+#include <linux/kernel.h>
+#include <linux/init.h>
+
+#include <mach/hardware.h>
+#include <asm/mach-types.h>
+#include <asm/mach/arch.h>
+#include <asm/mach/map.h>
+
+#include <plat/irqs.h>
+#include <plat/board.h>
+#include <plat/common.h>
+
+static struct omap_board_config_kernel ti8148_evm_config[] __initdata = {
+};
+
+static void __init ti8148_evm_init(void)
+{
+	omap_serial_init();
+	omap_board_config = ti8148_evm_config;
+	omap_board_config_size = ARRAY_SIZE(ti8148_evm_config);
+}
+
+static void __init ti8148_evm_map_io(void)
+{
+	omap2_set_globals_ti81xx();
+	omapti81xx_map_common_io();
+}
+
+MACHINE_START(TI8148EVM, "ti8148evm")
+	/* Maintainer: Texas Instruments */
+	.atag_offset	= 0x100,
+	.map_io		= ti8148_evm_map_io,
+	.init_early	= ti81xx_init_early,
+	.init_irq	= ti81xx_init_irq,
+	.timer		= &omap3_timer,
+	.init_machine	= ti8148_evm_init,
+MACHINE_END
diff --git a/arch/arm/plat-omap/include/plat/uncompress.h b/arch/arm/plat-omap/include/plat/uncompress.h
index 40336ad..8d052e7 100644
--- a/arch/arm/plat-omap/include/plat/uncompress.h
+++ b/arch/arm/plat-omap/include/plat/uncompress.h
@@ -175,6 +175,9 @@ static inline void __arch_decomp_setup(unsigned long arch_id)
 		/* TI8168 base boards using UART3 */
 		DEBUG_LL_TI81XX(3, ti8168evm);
 
+		/* TI8148 base boards using UART1 */
+		DEBUG_LL_TI81XX(1, ti8148evm);
+
 	} while (0);
 }
 
-- 
1.7.3.5

Re: [PATCH v2 3/3] TI814X: Create board support and enable build for TI8148 EVM

[Tony Lindgren]

* Hemant Pedanekar <hemantp@ti.com> [110921 10:05]:
> +
> +static struct omap_board_config_kernel ti8148_evm_config[] __initdata = {
> +};
> +
> +static void __init ti8148_evm_init(void)
> +{
> +	omap_serial_init();
> +	omap_board_config = ti8148_evm_config;
> +	omap_board_config_size = ARRAY_SIZE(ti8148_evm_config);
> +}
> +
> +static void __init ti8148_evm_map_io(void)
> +{
> +	omap2_set_globals_ti81xx();
> +	omapti81xx_map_common_io();
> +}

Hmm I guess we still have board specific map_io in board-ti8668evm.c
also. Those would be better replaced with ti81xx_map_io in
mach-omap2/common.c. Care to take a look at that?

> +MACHINE_START(TI8148EVM, "ti8148evm")
> +	/* Maintainer: Texas Instruments */
> +	.atag_offset	= 0x100,
> +	.map_io		= ti8148_evm_map_io,
> +	.init_early	= ti81xx_init_early,
> +	.init_irq	= ti81xx_init_irq,
> +	.timer		= &omap3_timer,
> +	.init_machine	= ti8148_evm_init,
> +MACHINE_END

Please add this all to board-ti8168evm.c instead of adding a new
board-*.c file. With the upcoming device tree conversion most of
these will disappear anyways.

Regards,

Tony

RE: [PATCH v2 3/3] TI814X: Create board support and enable build for TI8148 EVM

[Pedanekar, Hemant]

Tony Lindgren wrote on Thursday, September 22, 2011 2:18 AM:

> * Hemant Pedanekar <hemantp@ti.com> [110921 10:05]:
>> +
>> +static struct omap_board_config_kernel ti8148_evm_config[] __initdata = {
>> +}; +
>> +static void __init ti8148_evm_init(void)
>> +{
>> +	omap_serial_init();
>> +	omap_board_config = ti8148_evm_config;
>> +	omap_board_config_size = ARRAY_SIZE(ti8148_evm_config); +}
>> +
>> +static void __init ti8148_evm_map_io(void)
>> +{
>> +	omap2_set_globals_ti81xx();
>> +	omapti81xx_map_common_io();
>> +}
> 
> Hmm I guess we still have board specific map_io in board-ti8668evm.c
> also. Those would be better replaced with ti81xx_map_io in
> mach-omap2/common.c. Care to take a look at that?
>

Yes, you are right. I will do that.
 
>> +MACHINE_START(TI8148EVM, "ti8148evm")
>> +	/* Maintainer: Texas Instruments */
>> +	.atag_offset	= 0x100,
>> +	.map_io		= ti8148_evm_map_io,
>> +	.init_early	= ti81xx_init_early,
>> +	.init_irq	= ti81xx_init_irq,
>> +	.timer		= &omap3_timer,
>> +	.init_machine	= ti8148_evm_init,
>> +MACHINE_END
> 
> Please add this all to board-ti8168evm.c instead of adding a new
> board-*.c file. With the upcoming device tree conversion most of these will
> disappear anyways. 
>

Ok, I will do that.

Thanks.
   Hemant 
> Regards,
> 
> Tony



   Hemant