From: Archit Taneja <archit@ti.com>
To: hvaibhav@ti.com
Cc: tomi.valkeinen@ti.com, linux-omap@vger.kernel.org,
sumit.semwal@ti.com, linux-media@vger.kernel.org,
Archit Taneja <archit@ti.com>
Subject: [PATCH v2 5/5] OMAP_VOUT: Don't trigger updates in omap_vout_probe
Date: Mon, 26 Sep 2011 12:12:10 +0530 [thread overview]
Message-ID: <1317019330-4090-6-git-send-email-archit@ti.com> (raw)
In-Reply-To: <1317019330-4090-1-git-send-email-archit@ti.com>
Remove the code in omap_vout_probe() which calls display->driver->update() for
all the displays. This isn't correct because:
- An update in probe doesn't make sense, because we don't have any valid content
to show at this time.
- Calling update for a panel which isn't enabled is not supported by DSS2. This
leads to a crash at probe.
Signed-off-by: Archit Taneja <archit@ti.com>
---
drivers/media/video/omap/omap_vout.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/video/omap/omap_vout.c
index df0713c..5473601 100644
--- a/drivers/media/video/omap/omap_vout.c
+++ b/drivers/media/video/omap/omap_vout.c
@@ -2221,14 +2221,6 @@ static int __init omap_vout_probe(struct platform_device *pdev)
if (ret)
goto probe_err2;
- for (i = 0; i < vid_dev->num_displays; i++) {
- struct omap_dss_device *display = vid_dev->displays[i];
-
- if (display->driver->update)
- display->driver->update(display, 0, 0,
- display->panel.timings.x_res,
- display->panel.timings.y_res);
- }
return 0;
probe_err2:
--
1.7.1
prev parent reply other threads:[~2011-09-26 6:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 6:42 [PATCH v2 0/5] [media]: OMAP_VOUT: Misc fixes and cleanup patches for 3.2 Archit Taneja
2011-09-26 6:42 ` [PATCH v2 1/5] OMAP_VOUT: Fix check in reqbuf for buf_size allocation Archit Taneja
2011-09-26 6:42 ` [PATCH v2 2/5] OMAP_VOUT: CLEANUP: Remove redundant code from omap_vout_isr Archit Taneja
2011-09-26 6:42 ` [PATCH v2 3/5] OMAP_VOUT: Fix VSYNC IRQ handling in omap_vout_isr Archit Taneja
2011-09-26 6:42 ` [PATCH v2 4/5] OMAP_VOUT: Add support for DSI panels Archit Taneja
2011-09-26 6:42 ` Archit Taneja [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317019330-4090-6-git-send-email-archit@ti.com \
--to=archit@ti.com \
--cc=hvaibhav@ti.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sumit.semwal@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox