From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <archit@ti.com>
Cc: hvaibhav@ti.com, linux-omap@vger.kernel.org, sumit.semwal@ti.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3 4/4] OMAP_VOUT: Don't trigger updates in omap_vout_probe
Date: Tue, 27 Sep 2011 09:10:33 +0300 [thread overview]
Message-ID: <1317103833.1991.6.camel@deskari> (raw)
In-Reply-To: <1317038365-30650-5-git-send-email-archit@ti.com>
On Mon, 2011-09-26 at 17:29 +0530, Archit Taneja wrote:
> Remove the code in omap_vout_probe() which calls display->driver->update() for
> all the displays. This isn't correct because:
>
> - An update in probe doesn't make sense, because we don't have any valid content
> to show at this time.
> - Calling update for a panel which isn't enabled is not supported by DSS2. This
> leads to a crash at probe.
Calling update() on a disabled panel should not crash... Where is the
crash coming from?
Tomi
next prev parent reply other threads:[~2011-09-27 6:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 11:59 [PATCH v3 0/4] OMAP_VOUT: Misc fixes and cleanup patches for 3.2 Archit Taneja
2011-09-26 11:59 ` [PATCH v3 1/4] OMAP_VOUT: Fix check in reqbuf for buf_size allocation Archit Taneja
2011-09-27 7:19 ` Hiremath, Vaibhav
2011-09-27 7:23 ` Archit Taneja
2011-09-26 11:59 ` [PATCH v3 2/4] OMAP_VOUT: CLEANUP: Remove redundant code from omap_vout_isr Archit Taneja
2011-09-26 11:59 ` [PATCH v3 3/4] OMAP_VOUT: Add support for DSI panels Archit Taneja
2011-09-26 11:59 ` [PATCH v3 4/4] OMAP_VOUT: Don't trigger updates in omap_vout_probe Archit Taneja
2011-09-27 6:10 ` Tomi Valkeinen [this message]
2011-09-27 7:02 ` Archit Taneja
2011-09-27 7:07 ` Tomi Valkeinen
2011-09-27 7:15 ` Archit Taneja
2011-09-27 6:26 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317103833.1991.6.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=archit@ti.com \
--cc=hvaibhav@ti.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sumit.semwal@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox