From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: RE: [PATCH 3/5] [media]: OMAP_VOUT: Fix VSYNC IRQ handling in omap_vout_isr Date: Tue, 27 Sep 2011 09:49:07 +0300 Message-ID: <1317106147.1991.10.camel@deskari> References: <1316167233-1437-1-git-send-email-archit@ti.com> <1316167233-1437-4-git-send-email-archit@ti.com> <19F8576C6E063C45BE387C64729E739404EC941F86@dbde02.ent.ti.com> <4E7AD29C.4070804@ti.com> <19F8576C6E063C45BE387C64729E739404ECA54614@dbde02.ent.ti.com> <19F8576C6E063C45BE387C64729E739404ECA548CF@dbde02.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog124.obsmtp.com ([74.125.149.151]:54168 "EHLO na3sys009aog124.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751151Ab1I0GtM (ORCPT ); Tue, 27 Sep 2011 02:49:12 -0400 In-Reply-To: <19F8576C6E063C45BE387C64729E739404ECA548CF@dbde02.ent.ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Hiremath, Vaibhav" Cc: "Semwal, Sumit" , "Taneja, Archit" , "linux-omap@vger.kernel.org" , "linux-media@vger.kernel.org" On Tue, 2011-09-27 at 12:09 +0530, Hiremath, Vaibhav wrote: > Please look at the patch carefully, it does exactly same thing. I > understand the use-case what Archit explained in the last email but in > this patch context, the use-case change anything here in this patch. With the current code, the ISR code will be ran for a panel connected to LCD1 output when VSYNC for LCD2 happens. After Archit's patch, this no longer happens. I don't know what the ISR code does, so it may not cause any problems, but it sure doesn't sound right running the code when a wrong interrupt happens. Tomi