Re: [PATCH 2/2] OMAPDSS: HDMI: Disable HDMI DDC internal pull up

Tomi Valkeinen
2011-10-26T08:30:14Z

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

On Tue, 2011-10-25 at 15:05 +0530, K, Mythri P wrote:
> Hi,
>
> On Fri, Oct 21, 2011 at 4:49 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> > On Fri, 2011-10-21 at 14:57 +0530, mythripk@ti.com wrote:
> >> From: Mythri P K <mythripk@ti.com>
> >>
> >> Disables the internal pull resistor for SDA and SCL enabled by
> >> default as there are expernal pull up's to avoid the EDID read failure.
> >
> > What do you mean with external pull up? Outside OMAP? Then it's a board
> > specific feature, isn't it, and not related to the OMAP version?
> yes it is not specific to OMAP. SDP/Panda boards OMAP 4430 version
> ES2.3 and 4460 have this board change, but as there is not separate
> board file as such for these boards i have added the check as above.Do
> you have any other idea?

Well, in that case the code is obviously wrong. The choice whether to
enable or disable the pull up has to come from the board file.

Tomi

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]