Re: [PATCH 1/2] OMAPDSS: HDMI: Move duplicate code from boardfile to

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

On Tue, 2011-10-25 at 15:11 +0530, K, Mythri P wrote:
> Hi,
> 
> On Fri, Oct 21, 2011 at 4:42 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:

> > However, for DSI we need to change the pins during runtime, so that's
> > why the functions for DSI are required. If the HDMI configuration is
> > more static, and needs to be done only once at boot time, perhaps the
> > display_init function could go through the displays from the board_data,
> > and if there's an HDMI display defined, do the muxing.
> Mux configuration for HDMI is static unlike for DSI, Also i have added
> a check for OMAP4,

So you are sure the HDMI pins do not need to be muxed to safe-mode or
similar when HDMI is not in use, to avoid leak currencies, prevent
interference signals on the wires, etc?

That is the reason for the runtime DSI pin muxing.

> I am not aware of any OMAP4 board without the HDMI today.

Neither am I, but it doesn't mean there won't be.

> It appears to me that even other modules do their mux configuration in
> board-file.

Most of the mux config is done in other files than board files.

My point was that I don't want identical code in every board file which
supports HDMI. One option would be to implement omap_hdmi_mux_init
function, which takes as an argument whether the internal pull up has to
be enabled or not. And this function should be called from the board
files that have HDMI.

It's not perfect, as you still need to call the function, but it's much
better than having the identical muxing code in every board file.

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]