From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "K, Mythri P" <mythripk@ti.com>
Cc: linux-omap@vger.kernel.org,
Ricardo Salveti de Araujo <ricardo.salveti@linaro.org>
Subject: Re: [PATCH 2/2] OMAPDSS: HDMI: Disable HDMI DDC internal pull up
Date: Wed, 26 Oct 2011 11:30:09 +0300 [thread overview]
Message-ID: <1319617809.2097.40.camel@deskari> (raw)
In-Reply-To: <CAP5A+B8VxBZSDtPAfV9v2kH6RDLnXKvV9ODfvs5Zjo+EDOOnZQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
On Tue, 2011-10-25 at 15:05 +0530, K, Mythri P wrote:
> Hi,
>
> On Fri, Oct 21, 2011 at 4:49 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> > On Fri, 2011-10-21 at 14:57 +0530, mythripk@ti.com wrote:
> >> From: Mythri P K <mythripk@ti.com>
> >>
> >> Disables the internal pull resistor for SDA and SCL enabled by
> >> default as there are expernal pull up's to avoid the EDID read failure.
> >
> > What do you mean with external pull up? Outside OMAP? Then it's a board
> > specific feature, isn't it, and not related to the OMAP version?
> yes it is not specific to OMAP. SDP/Panda boards OMAP 4430 version
> ES2.3 and 4460 have this board change, but as there is not separate
> board file as such for these boards i have added the check as above.Do
> you have any other idea?
Well, in that case the code is obviously wrong. The choice whether to
enable or disable the pull up has to come from the board file.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-10-26 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-21 9:27 [PATCH 2/2] OMAPDSS: HDMI: Disable HDMI DDC internal pull up mythripk
2011-10-21 11:19 ` Tomi Valkeinen
2011-10-25 9:35 ` K, Mythri P
2011-10-26 8:30 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319617809.2097.40.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mythripk@ti.com \
--cc=ricardo.salveti@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox