public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Weber <weber@corscience.de>
To: tony@atomide.com
Cc: arnd@arndb.de, Thomas Weber <weber@corscience.de>,
	Russell King <linux@arm.linux.org.uk>,
	"open list:OMAP SUPPORT" <linux-omap@vger.kernel.org>,
	"open list:ARM PORT" <linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: [PATCH] ARM: OMAP3: Fix dependencies for OMAP3_EMU
Date: Sat,  5 Nov 2011 17:57:59 +0100	[thread overview]
Message-ID: <1320512279-9032-1-git-send-email-weber@corscience.de> (raw)

This patch fixes the dependencies for OMAP3_EMU after
commit 53eebb0df85e4005
ARM: OC_ETM should not select ARM_AMBA

When "OMAP3 debugging peripherals" is selected the warning:
(OMAP3_EMU) selects OC_ETM which
has unmet direct dependencies (ARM_AMBA)

appears, which results in:

arch/arm/kernel/built-in.o: In function `etm_remove':
arch/arm/kernel/etm.c:608:
undefined reference to `amba_release_regions'
arch/arm/kernel/built-in.o: In function `etb_remove':
arch/arm/kernel/etm.c:408:
undefined reference to `amba_release_regions'
arch/arm/kernel/built-in.o: In function `etm_init':
arch/arm/kernel/etm.c:639:
undefined reference to `amba_driver_register'
arch/arm/kernel/etm.c:645:
undefined reference to `amba_driver_register'
arch/arm/kernel/etm.c:647:
undefined reference to `amba_driver_unregister'
arch/arm/kernel/built-in.o: In function `etm_probe':
arch/arm/kernel/etm.c:544:
undefined reference to `amba_request_regions'
arch/arm/kernel/etm.c:594:
undefined reference to `amba_release_regions'
arch/arm/kernel/built-in.o: In function `etb_probe':
arch/arm/kernel/etm.c:346:
undefined reference to `amba_request_regions'
arch/arm/kernel/etm.c:391:
undefined reference to `amba_release_regions'
arch/arm/mach-omap2/built-in.o: In function `emu_init':
arch/arm/mach-omap2/emu.c:62:
undefined reference to `amba_device_register'
arch/arm/mach-omap2/emu.c:63:
undefined reference to `amba_device_register'
make: *** [.tmp_vmlinux1] Error 1

Signed-off-by: Thomas Weber <weber@corscience.de>
---
 arch/arm/mach-omap2/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index c3d530b..9c5354a 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -30,6 +30,7 @@ config ARCH_OMAP3
 	bool "TI OMAP3"
 	depends on ARCH_OMAP2PLUS
 	default y
+	select ARM_AMBA
 	select CPU_V7
 	select USB_ARCH_HAS_EHCI
 	select ARM_L1_CACHE_SHIFT_6 if !ARCH_OMAP4
-- 
1.7.7.2

             reply	other threads:[~2011-11-05 16:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-05 16:57 Thomas Weber [this message]
2011-11-05 16:00 ` [PATCH] ARM: OMAP3: Fix dependencies for OMAP3_EMU Russell King - ARM Linux
2011-11-05 17:51   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320512279-9032-1-git-send-email-weber@corscience.de \
    --to=weber@corscience.de \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox