From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "K, Mythri P" <mythripk@ti.com>
Cc: linux-omap@vger.kernel.org,
Ricardo Salveti de Araujo <ricardo.salveti@linaro.org>
Subject: Re: [PATCH v3 2/2] OMAPDSS: HDMI: Disable DDC internal pull up
Date: Tue, 22 Nov 2011 15:19:28 +0200 [thread overview]
Message-ID: <1321967968.1887.70.camel@deskari> (raw)
In-Reply-To: <CAP5A+B8Cv=knJwzRvGg4D2t3g=-bykam9iksHh9UXH4pmCB96Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
On Tue, 2011-11-22 at 18:37 +0530, K, Mythri P wrote:
> >> + if (cpu_is_omap446x() || (omap_rev() > OMAP4430_REV_ES2_2))
> >
> > If you compare omap_rev() you should also use cpu_is_omap at the
> same
> > time. In this case (cpu_is_omap443x() && omap_rev() >
> > OMAP4430_REV_ES2_2). Otherwise the omap_rev check could match, say,
> > omap3 or omap5 boards.
> Hmmm I am not really sure if that is needed, I dont think omap3 or
> omap5 boards would be named with rev "OMAP4430"_REV_ES2_2 ???
OMAP4430_REV_ES2_2 is just a symbolic name for a define for some number.
There's no reason why OMAP3430_REV_ES1_0 wouldn't be defined to the same
number.
That said, looking at arch/arm/plat-omap/include/plat/cpu.h shows that
the REV defines do include an OMAP class number, and so omap_rev() does
return a number with cpu ID. So it seems you indeed do not need
cpu_is_omap443x() there.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-22 13:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 13:50 [PATCH v3 2/2] OMAPDSS: HDMI: Disable DDC internal pull up mythripk
2011-11-18 7:30 ` Tomi Valkeinen
2011-11-22 13:07 ` K, Mythri P
2011-11-22 13:19 ` Tomi Valkeinen [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-20 8:38 [PATCH v2 1/2] OMAPDSS: HDMI: Move duplicate code from boardfile mythripk
2011-12-20 8:38 ` [PATCH v3 2/2] OMAPDSS: HDMI: Disable DDC internal pull up mythripk
2011-12-20 8:56 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321967968.1887.70.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mythripk@ti.com \
--cc=ricardo.salveti@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox