Re: [PATCHv6 1/6] regulator: core: add support for external get/set_voltage

Mark Brown
2011-11-25T17:29:55Z

On Fri, Nov 25, 2011 at 07:20:32PM +0200, Tero Kristo wrote:
> On Fri, 2011-11-25 at 16:52 +0000, Mark Brown wrote:

> > My basic reaction to this is "eew, ick". Doing this with a runtime call
> > just feels badly joined up, and there's nothing here which hands off the
> > configuration between the various drivers involved in the transitions.
> > We need to make sure that the voltage doesn't suddenly lurch around when
> > doing transitions.

> Would you feel better if we just hacked around with the twl-regulator
> driver and added a compile time switch for the voltage get/set for smps
> regulators?

No, that's clearly going to break multi-board kernel images. If this
is something board specific platform/device tree data sounds like the
way forwards.