From: Tero Kristo <t-kristo@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-omap@vger.kernel.org, khilman@ti.com, lrg@ti.com,
gg@slimlogic.co.uk, rnayak@ti.com, b-cousson@ti.com
Subject: Re: [PATCHv6 1/6] regulator: core: add support for external get/set_voltage
Date: Mon, 28 Nov 2011 10:15:41 +0200 [thread overview]
Message-ID: <1322468141.4489.5.camel@sokoban> (raw)
In-Reply-To: <20111125184832.GK5315@opensource.wolfsonmicro.com>
On Fri, 2011-11-25 at 18:48 +0000, Mark Brown wrote:
> On Fri, Nov 25, 2011 at 07:59:03PM +0200, Tero Kristo wrote:
> > On Fri, 2011-11-25 at 17:29 +0000, Mark Brown wrote:
>
> > > No, that's clearly going to break multi-board kernel images. If this
> > > is something board specific platform/device tree data sounds like the
> > > way forwards.
>
> > Okay, so I will update this patch with proper locking and you should be
> > okay with that approach? Usually in the omap case we just want to switch
> > to using the external controller during init time and leave it be like
> > that, there is no really use-case as such for runtime switching of
> > controller, except maybe for some experimental / debug usage.
>
> No - as I said "platform/device tree data sounds like the way forwards."
Ok thanks, I'll take a look at this and try to forge the code into a
platform data type solution.
-Tero
next prev parent reply other threads:[~2011-11-28 8:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 16:29 [PATCHv6 0/6] OMAP: SMPS support for TWL regulators Tero Kristo
2011-11-25 16:29 ` [PATCHv6 1/6] regulator: core: add support for external get/set_voltage Tero Kristo
2011-11-25 16:52 ` Mark Brown
2011-11-25 17:20 ` Tero Kristo
2011-11-25 17:29 ` Mark Brown
2011-11-25 17:59 ` Tero Kristo
2011-11-25 18:48 ` Mark Brown
2011-11-28 8:15 ` Tero Kristo [this message]
2011-11-25 16:29 ` [PATCHv6 2/6] omap3: add common twl configurations for vdd1 and vdd2 Tero Kristo
2011-11-25 16:29 ` [PATCHv6 3/6] TEMP: OMAP3: beagle rev-c4: enable OPP6 Tero Kristo
2011-11-25 16:29 ` [PATCHv6 4/6] regulator: twl: fix twl4030 support for smps regulators Tero Kristo
2011-11-25 16:55 ` Mark Brown
2011-11-25 17:08 ` Tero Kristo
2011-11-25 16:29 ` [PATCHv6 5/6] omap3: voltage: fix channel configuration Tero Kristo
2011-11-25 16:29 ` [PATCHv6 6/6] omap3: voltage: add external controller for VDD1 and VDD2 Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322468141.4489.5.camel@sokoban \
--to=t-kristo@ti.com \
--cc=b-cousson@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox