Re: [PATCH 58/65] OMAPDSS: APPLY: add wait_pending_extra_info_updates()

Tomi Valkeinen
2011-12-07T13:15:15Z

[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]

On Wed, 2011-12-07 at 18:37 +0530, Archit Taneja wrote:
> On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote:

> > +/* wait until no extra_info updates are pending */
> > +static void wait_pending_extra_info_updates(void)
> > +{
> > + bool updating;
> > + unsigned long flags;
> > + unsigned long t;
> > +
> > + spin_lock_irqsave(&data_lock, flags);
> > +
> > + updating = extra_info_update_ongoing();
> > +
> > + if (!updating) {
> > + spin_unlock_irqrestore(&data_lock, flags);
> > + return;
> > + }
> > +
> > + init_completion(&extra_updated_completion);
> > +
> > + spin_unlock_irqrestore(&data_lock, flags);
> > +
> > + t = msecs_to_jiffies(500);
> > + wait_for_completion_timeout(&extra_updated_completion, t);
> > +
> > + updating = extra_info_update_ongoing();
> > +
> > + WARN_ON(updating);
> > +}
>
> This function isn't used, are you planning to use it later?

Yes, it's used with the fifo-merge stuff. It could be added later, but
as it's related to the extra_info stuff, I think it fits better here
than with the fifo merge series.

Tomi

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]