linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tarun Kanti DebBarma <tarun.kanti@ti.com>
To: linux-omap@vger.kernel.org
Cc: khilman@ti.com, tony@atomide.com,
	linux-arm-kernel@lists.infradead.org,
	Tarun Kanti DebBarma <tarun.kanti@ti.com>
Subject: [PATCH v9 17/31] gpio/omap: optimize suspend and resume functions
Date: Wed, 14 Dec 2011 01:50:19 +0530	[thread overview]
Message-ID: <1323807633-23713-18-git-send-email-tarun.kanti@ti.com> (raw)
In-Reply-To: <1323807633-23713-1-git-send-email-tarun.kanti@ti.com>

There is no need to operate on all the banks every time the function is called.
Just operate on the current bank passed by the framework.

Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
 drivers/gpio/gpio-omap.c |   54 ++++++++++++++++++++++++---------------------
 1 files changed, 29 insertions(+), 25 deletions(-)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index e5dd3bb..174aa06 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1055,6 +1055,8 @@ static int __devinit omap_gpio_probe(struct platform_device *pdev)
 		goto err_free;
 	}
 
+	platform_set_drvdata(pdev, bank);
+
 	pm_runtime_enable(bank->dev);
 	pm_runtime_irq_safe(bank->dev);
 	pm_runtime_get_sync(bank->dev);
@@ -1082,44 +1084,46 @@ err_exit:
 
 static int omap_gpio_suspend(struct device *dev)
 {
-	struct gpio_bank *bank;
+	struct platform_device *pdev = to_platform_device(dev);
+	struct gpio_bank *bank = platform_get_drvdata(pdev);
+	void __iomem *base = bank->base;
+	void __iomem *wakeup_enable;
+	unsigned long flags;
 
-	list_for_each_entry(bank, &omap_gpio_list, node) {
-		void __iomem *base = bank->base;
-		void __iomem *wake_status;
-		unsigned long flags;
+	if (!bank->mod_usage || !bank->loses_context)
+		return 0;
 
-		if (!bank->regs->wkup_en)
-			return 0;
+	if (!bank->regs->wkup_en || !bank->suspend_wakeup)
+		return 0;
 
-		wake_status = bank->base + bank->regs->wkup_en;
+	wakeup_enable = bank->base + bank->regs->wkup_en;
 
-		spin_lock_irqsave(&bank->lock, flags);
-		bank->saved_wakeup = __raw_readl(wake_status);
-		_gpio_rmw(base, bank->regs->wkup_en, 0xffffffff, 0);
-		_gpio_rmw(base, bank->regs->wkup_en, bank->suspend_wakeup, 1);
-		spin_unlock_irqrestore(&bank->lock, flags);
-	}
+	spin_lock_irqsave(&bank->lock, flags);
+	bank->saved_wakeup = __raw_readl(wakeup_enable);
+	_gpio_rmw(base, bank->regs->wkup_en, 0xffffffff, 0);
+	_gpio_rmw(base, bank->regs->wkup_en, bank->suspend_wakeup, 1);
+	spin_unlock_irqrestore(&bank->lock, flags);
 
 	return 0;
 }
 
 static int omap_gpio_resume(struct device *dev)
 {
-	struct gpio_bank *bank;
+	struct platform_device *pdev = to_platform_device(dev);
+	struct gpio_bank *bank = platform_get_drvdata(pdev);
+	void __iomem *base = bank->base;
+	unsigned long flags;
 
-	list_for_each_entry(bank, &omap_gpio_list, node) {
-		void __iomem *base = bank->base;
-		unsigned long flags;
+	if (!bank->mod_usage || !bank->loses_context)
+		return 0;
 
-		if (!bank->regs->wkup_en)
-			return 0;
+	if (!bank->regs->wkup_en || !bank->saved_wakeup)
+		return 0;
 
-		spin_lock_irqsave(&bank->lock, flags);
-		_gpio_rmw(base, bank->regs->wkup_en, 0xffffffff, 0);
-		_gpio_rmw(base, bank->regs->wkup_en, bank->saved_wakeup, 1);
-		spin_unlock_irqrestore(&bank->lock, flags);
-	}
+	spin_lock_irqsave(&bank->lock, flags);
+	_gpio_rmw(base, bank->regs->wkup_en, 0xffffffff, 0);
+	_gpio_rmw(base, bank->regs->wkup_en, bank->saved_wakeup, 1);
+	spin_unlock_irqrestore(&bank->lock, flags);
 
 	return 0;
 }
-- 
1.7.0.4


  parent reply	other threads:[~2011-12-13 20:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-13 20:20 [PATCH v9 00/31] gpio/omap: driver cleanup and fixes Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 01/31] gpio/omap: remove dependency on gpio_bank_count Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 02/31] gpio/omap: use flag to identify wakeup domain Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 03/31] gpio/omap: make gpio_context part of gpio_bank structure Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 04/31] gpio/omap: handle save/restore context in GPIO driver Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 05/31] gpio/omap: make non-wakeup GPIO part of pdata Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 06/31] gpio/omap: avoid cpu checks during module ena/disable Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 07/31] gpio/omap: further cleanup using wkup_en register Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 08/31] gpio/omap: use level/edge detect reg offsets Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 09/31] gpio/omap: remove hardcoded offsets in context save/restore Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 10/31] gpio/omap: cleanup set_gpio_triggering function Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 11/31] gpio/omap: cleanup omap_gpio_mod_init function Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 12/31] gpio/omap: use pinctrl offset instead of macro Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 13/31] gpio/omap: remove unnecessary bit-masking for read access Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 14/31] gpio/omap: remove bank->method & METHOD_* macros Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 15/31] gpio/omap: fix bankwidth for OMAP7xx MPUIO Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 16/31] gpio/omap: use pm-runtime framework Tarun Kanti DebBarma
2011-12-13 20:20 ` Tarun Kanti DebBarma [this message]
2011-12-13 20:20 ` [PATCH v9 18/31] gpio/omap: cleanup prepare_for_idle and resume_after_idle Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 19/31] gpio/omap: fix debounce clock handling Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 20/31] gpio/omap: fix incorrect access of debounce module Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 21/31] gpio/omap: remove omap_gpio_save_context overhead Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 22/31] gpio/omap: save and restore debounce registers Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 23/31] gpio/omap: enable irq at the end of all configuration in restore Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 24/31] gpio/omap: restore OE only after setting the output level Tarun Kanti DebBarma
2011-12-13 20:20 ` [PATCH v9 25/31] gpio/omap: handle set_dataout reg capable IP on restore Tarun Kanti DebBarma
2011-12-16  7:28 ` [PATCH v9 00/31] gpio/omap: driver cleanup and fixes Shilimkar, Santosh
2011-12-16  8:24   ` DebBarma, Tarun Kanti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323807633-23713-18-git-send-email-tarun.kanti@ti.com \
    --to=tarun.kanti@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).