public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Ricardo Neri <ricardo.neri@ti.com>,
	b-cousson@ti.com, linux-omap@vger.kernel.org, mythripk@ti.com,
	s-guiriec@ti.com, lrg@ti.com, peter.ujfalusi@ti.com
Subject: Re: [PATCH] ASoC: OMAP: HDMI: Prevent DSS module from going idle when playing audio
Date: Fri, 16 Dec 2011 10:18:24 +0200	[thread overview]
Message-ID: <1324023504.1859.11.camel@deskari> (raw)
In-Reply-To: <alpine.DEB.2.00.1112160107380.12660@utopia.booyaka.com>

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

On Fri, 2011-12-16 at 01:14 -0700, Paul Walmsley wrote:
> > @@ -572,12 +573,16 @@ int hdmi_audio_trigger(struct
> snd_pcm_substream *substream, int cmd,
> >       case SNDRV_PCM_TRIGGER_START:
> >       case SNDRV_PCM_TRIGGER_RESUME:
> >       case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
> > +             omap_hwmod_set_slave_idlemode(ip_data->oh,
> > +                     HWMOD_IDLEMODE_NO);
> 
> omap_hwmod functions should not be called from device driver code.
> Device 
> drivers should be completely independent of architecture and 
> subarchitecture code.  If you need to do something like this, the way
> to 
> do it is to call an omap_device function through a platform_data
> function 
> pointer.  You may need to create omap_device and/or omap_hwmod
> functions 
> to do what you want to do. 

But with DT we can't use func pointers in platform_data either, right?

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2011-12-16  8:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-16  7:03 [PATCH] ASoC: OMAP: HDMI: Prevent DSS module from going idle when playing audio Ricardo Neri
2011-12-16  8:14 ` Paul Walmsley
2011-12-16  8:18   ` Tomi Valkeinen [this message]
2011-12-16  8:27     ` Paul Walmsley
2011-12-16  8:47       ` Tomi Valkeinen
2011-12-16  9:09         ` Paul Walmsley
2011-12-16  9:11         ` Cousson, Benoit
2011-12-16  9:13         ` Paul Walmsley
2011-12-16 17:19           ` Tony Lindgren
2011-12-16 20:52             ` Paul Walmsley
2011-12-16 20:59               ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324023504.1859.11.camel@deskari \
    --to=tomi.valkeinen@ti.com \
    --cc=b-cousson@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=mythripk@ti.com \
    --cc=paul@pwsan.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=ricardo.neri@ti.com \
    --cc=s-guiriec@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox