Re: [PATCH 2/2] OMAPDSS: HDMI: Disable DDC internal pull up

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]

On Mon, 2011-12-19 at 13:56 +0530, K, Mythri P wrote:
> >> +     /*
> >> +      * CONTROL_I2C_1: HDMI_DDC_SDA_PULLUPRESX (bit 28) and
> >> +      * HDMI_DDC_SCL_PULLUPRESX (bit 24) are set to disable
> >> +      * internal pull up resistor - This is a change needed in
> >> +      * OMAP4460SDP/Blaze and OMAP4430 ES2.3 SDP/Blaze Boards as
> the
> >> +      * external pull up are present. This is needed to avoid
> >> +      * EDID read failure.
> >> +      */
> >
> Well CONTROL_I2C_1: HDMI_DDC_SDA_PULLUPRESX (bit 28) and
> HDMI_DDC_SCL_PULLUPRESX (bit 24) are marked as reserved bits in TRM
> and hence dont feature there so wanted to add to make clear as to what
> these bits mean, I can remove. 

It is fine to have the comments (and even good, if they are indeed not
mentioned in the TRM). My point was that the comments are in the wrong
place. You are not writing the bits in the board file, where the
comments are. You are writing the bits in display.c, which is where the
comments should be.

So in the board file you should have comment about the pull up without
the exact bit details, like I gave the example:

> "OMAP4460SDP/Blaze and OMAP4430 ES2.3 SDP/Blaze boards and later have
> external pull up on the HDMI I2C lines."

And in the display.c you can give details about the bits, if required.

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]