linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Daniel Mack <zonque@gmail.com>
Cc: linux-omap@vger.kernel.org,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Subject: Re: [PATCH v2] OMAP: DSS2: Support for UMSH-8173MD TFT panel
Date: Tue, 20 Dec 2011 10:40:36 +0200	[thread overview]
Message-ID: <1324370436.2042.4.camel@deskari> (raw)
In-Reply-To: <1324056624-16283-1-git-send-email-zonque@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

Hi,

On Fri, 2011-12-16 at 18:30 +0100, Daniel Mack wrote:
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> ---
> 
> v2 is a resent with ".power_on_delay" and ".acb" values corrected.

The code itself is fine, but please provide a commit description.
Patches should always have a commit description, even if the patch is
trivial and the desc would be more or less the same as the subject.

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2011-12-20  8:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-16 17:23 [PATCH] OMAP: DSS2: Support for UMSH-8173MD TFT panel Daniel Mack
2011-12-16 17:30 ` [PATCH v2] " Daniel Mack
2011-12-20  8:40   ` Tomi Valkeinen [this message]
2011-12-20  9:54     ` [PATCH v3] " Daniel Mack
2011-12-22 23:03       ` Daniel Mack
2012-01-03  9:21       ` Tomi Valkeinen
2012-01-03 10:36         ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324370436.2042.4.camel@deskari \
    --to=tomi.valkeinen@ti.com \
    --cc=FlorianSchandinat@gmx.de \
    --cc=linux-omap@vger.kernel.org \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).