From: Ilya Yanok <yanok@emcraft.com>
To: linux-omap@vger.kernel.org, linux-arm-kernel@infradead.org
Cc: sasha_d@emcraft.com, Ilya Yanok <yanok@emcraft.com>,
Igor Grinberg <grinberg@compulab.co.il>
Subject: [PATCH V2] OMAP2+: ads7846_init: put gpio_pendown into pdata if it's provided
Date: Thu, 22 Dec 2011 15:00:48 +0100 [thread overview]
Message-ID: <1324562448-24066-1-git-send-email-yanok@emcraft.com> (raw)
If platform data is provided by the caller gpio_pendown is put into
unused static ads7846_config structure and effectively has no effect.
Of course caller can set gpio_pendown field in platform data himself
but it seems natural to do this in ads7846_init to remove duplication.
Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
Signed-off-by: Ilya Yanok <yanok@emcraft.com>
---
Changes from V1:
- existing if clause reused
arch/arm/mach-omap2/common-board-devices.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/common-board-devices.c b/arch/arm/mach-omap2/common-board-devices.c
index 2d1d775..9498b0f 100644
--- a/arch/arm/mach-omap2/common-board-devices.c
+++ b/arch/arm/mach-omap2/common-board-devices.c
@@ -75,13 +75,15 @@ void __init omap_ads7846_init(int bus_num, int gpio_pendown, int gpio_debounce,
gpio_set_debounce(gpio_pendown, gpio_debounce);
}
- ads7846_config.gpio_pendown = gpio_pendown;
-
spi_bi->bus_num = bus_num;
spi_bi->irq = OMAP_GPIO_IRQ(gpio_pendown);
- if (board_pdata)
+ if (board_pdata) {
+ board_pdata->gpio_pendown = gpio_pendown;
spi_bi->platform_data = board_pdata;
+ } else {
+ ads7846_config.gpio_pendown = gpio_pendown;
+ }
spi_register_board_info(&ads7846_spi_board_info, 1);
}
--
1.7.6.4
next reply other threads:[~2011-12-22 14:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 14:00 Ilya Yanok [this message]
2012-03-05 19:58 ` [PATCH V2] OMAP2+: ads7846_init: put gpio_pendown into pdata if it's provided Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324562448-24066-1-git-send-email-yanok@emcraft.com \
--to=yanok@emcraft.com \
--cc=grinberg@compulab.co.il \
--cc=linux-arm-kernel@infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=sasha_d@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).