Re: [PATCH v3] OMAP: DSS2: Support for UMSH-8173MD TFT panel

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]

On Tue, 2011-12-20 at 10:54 +0100, Daniel Mack wrote:
> This patch adds support for Microtip Technologies' UMSH-8173MD 800x480
> RGB TFT panel. Tested with an OMAP3 board.
> 
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> ---
>  drivers/video/omap2/displays/panel-generic-dpi.c |   25 ++++++++++++++++++++++
>  1 files changed, 25 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/omap2/displays/panel-generic-dpi.c b/drivers/video/omap2/displays/panel-generic-dpi.c
> index 519c47d..cbcf164 100644
> --- a/drivers/video/omap2/displays/panel-generic-dpi.c
> +++ b/drivers/video/omap2/displays/panel-generic-dpi.c
> @@ -297,6 +297,31 @@ static struct panel_config generic_dpi_panels[] = {
>  
>  		.name			= "apollon",
>  	},
> +
> +	/* Microtips Technologies - UMSH-8173MD */
> +	{
> +		{
> +			.x_res		= 800,
> +			.y_res		= 480,
> +
> +			.pixel_clock	= 34560,
> +
> +			.hsw		= 13,
> +			.hfp		= 101,
> +			.hbp		= 101,
> +
> +			.vsw		= 23,
> +			.vfp		= 1,
> +			.vbp		= 1,
> +		},
> +		.acbi			= 0x0,
> +		.acb			= 0x0,
> +		.config			= OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
> +					  OMAP_DSS_LCD_IHS | OMAP_DSS_LCD_IPC,
> +		.power_on_delay		= 0,
> +		.power_off_delay	= 0,
> +		.name			= "UMSH-8173MD",

Looks fine, except the panel name is not in line with the other panel
names. I suggest "microtips_umsh_8173md". I can apply the patch and
make the change if you are ok with the name.

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]