Re: [PATCH v4 0/2] OMAPDSS: HDMI: Boardfile cleanup

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

On Mon, 2012-01-02 at 14:02 +0530, mythripk@ti.com wrote:
> From: Mythri P K <mythripk@ti.com>
> 
> Clean up of boardfiles to have the functions common to differnt boards in a
> common display file, Also in some OMAP4 boards external pull-up's are enabled
> thus enabling internal pull up should be a parameter from the boardfile.
> 
> changes since v3 : Comment improvement to move some portion from boardfile to
> display.
> changes since v2 : Make the flag as enum.
> changes since v1 : Make omap hdmi_init generic to handle different parameters
> and pass the pull up as a flag instead of int. 
> 
> Mythri P K (2):
>   OMAPDSS: HDMI: Move duplicate code from boardfile
>   OMAPDSS: HDMI: Disable DDC internal pull up
> 
>  arch/arm/mach-omap2/board-4430sdp.c    |   23 ++++++------------
>  arch/arm/mach-omap2/board-omap4panda.c |   25 +++++++-------------
>  arch/arm/mach-omap2/display.c          |   39 ++++++++++++++++++++++++++++++++
>  include/video/omapdss.h                |    6 +++++
>  4 files changed, 62 insertions(+), 31 deletions(-)

These look fine, I'll apply to DSS tree.

Btw, do you know what is the reason to use an external pull-up on the
newer boards? Is the internal pull-up somehow insufficient?

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]