Re: PM(?) problems on v3.3-rc1 on OMAP3

Tomi Valkeinen
2012-01-23T10:48:42Z

[-- Attachment #1: Type: text/plain, Size: 1477 bytes --]

On Mon, 2012-01-23 at 02:31 -0700, Paul Walmsley wrote:
> On Mon, 23 Jan 2012, Tomi Valkeinen wrote:
>
> > On Mon, 2012-01-23 at 02:04 -0700, Paul Walmsley wrote:
> > > On Mon, 23 Jan 2012, Tomi Valkeinen wrote:
> > >
> > > > Then I noticed that the DISPC's ENWAKEUP is not set. Setting ENWAKEUP
> > > > (with SIDLEMODE/IDLEMODE in smart mode) also removes the problem.
> > >
> > > Sounds like you've nailed it.
> > >
> > > What is perplexing is that the hwmod code should be setting this by
> > > default in omap_hwmod.c:_enable_sysc(). I wonder why that is not
> > > happening.
> >
> > It seems the omap2_dispc_sysc is missing SYSC_HAS_ENAWAKEUP. I wonder if
> > that's a mistake or by purpose...
>
> That's almost certainly a mistake. It's documented in the 34xx vZR TRM
> and so far I don't know of any reason for omitting any of those bits.
>
> I just searched my linux-omap folder for the original patch for this. It
> seems to be
>
> Date: Mon, 3 Jan 2011 18:20:53 +0530
> From: Guruswamy Senthilvadivu <svadivu@ti.com>
> Subject: [PATCH v3 01/17] OMAP2420: hwmod data: add DSS DISPC RFBI VENC
>
> and it was missing in that patch. Guess I missed it when I reviewed this
> patch. Sigh...
>
> Want to spin a quick patch for v3.3-rc1 to add it?

I think there are other bits missing also. CLOCKACTIVITY is missing for
DISPC. And DSI doesn't have any SYSC flags defined... I'll try to go
through them all.

Tomi

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]