Re: PM(?) problems on v3.3-rc1 on OMAP3

Tomi Valkeinen
2012-01-23T11:06:32Z

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

On Mon, 2012-01-23 at 04:02 -0700, Paul Walmsley wrote:
> On Mon, 23 Jan 2012, Tomi Valkeinen wrote:
>
> > On Mon, 2012-01-23 at 02:31 -0700, Paul Walmsley wrote:
> >
> > > Want to spin a quick patch for v3.3-rc1 to add it?
> >
> > I think there are other bits missing also. CLOCKACTIVITY is missing for
> > DISPC. And DSI doesn't have any SYSC flags defined... I'll try to go
> > through them all.
>
> Might be best to do a minimal patch for the 3.3-rc series and stable trees
> that just sets the SYSC_HAS_ENAWAKEUP flag? Then we can queue up a
> larger patch to fix the rest of the bits for the 3.4 merge window...

True. But the patch will be slightly larger than just trivial flag
addition, as OMAP2 doesn't have ENWAKEUP, and the current dispc
hwmod_class is shared between OMAP2 and OMAP3.

So I guess I'll split that and add ENWAKEUP to OMAP3's hwmod data.

And regarding clock activity, it seems a flag HWMOD_SET_DEFAULT_CLOCKACT
is also needed before the clockactivity is set to HW. But there's a XXX
comment above it, and I'm not sure what that's about.

Tomi

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]