Re: OMAP34xx

Tony Lindgren
2012-02-05T17:47:04Z

* Russell King - ARM Linux <linux@arm.linux.org.uk> [120205 08:54]:
> I'm also getting on the OMAP4430SDP:
>
> Error setting wl12xx data
>
> What a wonderfully descriptive error message. Not. What happened to
> saying _why_ we couldn't set the data? As for this:
>
> platform_device_register(&omap_vwlan_device);
>
> and not checking the return code, I really don't see why anyone bothered
> even reporting that wl12xx_set_platform_data() failed... why not just
> leave people in the dark over the error...
>
> Right, so, this "error" is happening because the WL12xx driver is not
> configured, and from what I can see, the WL12xx is something you'd plug
> in to the board instead of the SD card. So it makes no sense to report
> an error for a driver for a bit of hardware which is optional.
>
> So... my patch gets larger and gets this fixed for all platforms in
> mach-omap2.

That sounds like a good clean-up for next merge window.

> PRCM: failed to allocate irq descs: -12
>
> Does OMAP require sparse IRQ, or is NR_IRQS not set sufficiently high for
> OMAP? I can't work this one out, and it looks like things are missing for
> this to even work (did something in plat/irqs.h get missed?)

Tero, can you please investigate this?

Regards,

Tony