Re: OMAP34xx

Tony Lindgren
2012-02-04T23:09:19Z

* Russell King - ARM Linux <linux@arm.linux.org.uk> [120204 12:22]:
> On Sat, Feb 04, 2012 at 08:34:53PM +0000, Russell King - ARM Linux wrote:
> > And OMAP4 doesn't build. Fixing the build error in prm44xx.c (which is
> > virtually the same as the OMAP3 build error in its prm file) gets us to
> > a buildable state, but... it silently fails to boot.
> >
> > arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
>
> BTW, I can tell you why you don't see this error - you're building with
> DT enabled, which gives you this header path to those definitions:
>
> arch/arm/mach-omap2/prm44xx.c
> arch/arm/mach-omap2/common.h
> plat/common.h
> plat/i2c.h
> linux/i2c.h
> linux/of.h
> asm/prom.h
> asm/irq.h
> mach/irqs.h
> plat/irqs.h
> plat/irqs-44xx.h
>
> which, I think you'll agree, is a recipe for disaster if any one of those
> decides not to include its child at some point either via configuration
> or via mere deletion of an include.

OK. Sounds like the solution here is to include irqs.h directly
in prmx44xx.c.

Regards,

Tony