Re: OMAP34xx

Russell King - ARM Linux
2012-02-07T08:41:30Z

On Tue, Feb 07, 2012 at 01:54:57AM +0100, Cousson, Benoit wrote:
> Hi Russell,
>
> On 2/7/2012 1:24 AM, Russell King - ARM Linux wrote:
>> On Tue, Feb 07, 2012 at 12:19:50AM +0100, Cousson, Benoit wrote:
>>> In theory that patch should not be even needed.
>>
>> In theory that change is needed to fix the obviously broken code which
>> is there at the moment.
>
> Well, both patches were supposed to be merged during the last merge
> window, so this code is not broken

You're talking out your arse. It's fucked, because:

domain.irq_base = pdata->irq_base;
domain.nr_irq = nr_irqs;
#ifdef CONFIG_OF_IRQ
domain.of_node = of_node_get(node);
domain.ops = &irq_domain_simple_ops;
#endif
irq_domain_add(&domain);

YOU MUST NEVER EVER REGISTER AN IRQ DOMAIN WITH A NULL .ops MEMBER OTHERWISE
THE KERNEL IS GUARANTEED TO OOPS.

I don't care whether you think "oh, but OF_IRQ should have been set".
That's not the point. The fact is, how this code is _currently_ written,
it is _broken_ and therefore this code needs fixing.