Re: OMAP34xx

Cousson, Benoit
2012-02-07T05:27:09Z

On 2/7/2012 5:35 AM, Grant Likely wrote:
> On Mon, Feb 6, 2012 at 5:24 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
>> On Tue, Feb 07, 2012 at 12:19:50AM +0100, Cousson, Benoit wrote:
>>> In theory that patch should not be even needed.
>>
>> In theory that change is needed to fix the obviously broken code which
>> is there at the moment.
>>
>> So, irrespective of whether OF gets permanently enabled or not, that ifdef
>> needs to go.
>>
>> But, forcing OF on at this point probably isn't a good idea (who knows
>> what else is lurking there) and there's a fairly simple and tested fix
>> for this as I've shown in my OMAP patch.
>>
>> That, I feel, is likely to have less side effects than force enabling
>> USE_OF.
>
> +1. Fix the obvious bug in 3.3. In 3.4 this hunk of code is going to
> be replaced anyway.

Yeah, but that's the point. You can fix that by either adding some more
#ifdef in the driver knowing that this code will be completely removed
in the next merge window, or you can fix that by adding the USE_OF in
the omap2+ defconfig like it was supposed to be done originally.

The first one is a temp fix that will be thrown away whereas the second
approach is the long term solution we have to implement anyway.

It looks to me that doing the long term solution instead of the temp fix
is much more efficient and will avoid un-necessary churn.

Moreover, with Rob latest series, IRQ_DOMAIN will be enabled on every
ARM platform, so the "depend IRQ_DOMAIN" that "fix" is removing right
now will have to be added again once we will move that code to use
genirq domain support.
Again, that seems to be a lot of churn for nothing...

Anyway, I guess it is Tony's call at the end, so I let him decide.

Regards,
Benoit