Re: OMAP34xx

Grant Likely
2012-02-07T04:35:36Z

On Mon, Feb 6, 2012 at 5:24 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Tue, Feb 07, 2012 at 12:19:50AM +0100, Cousson, Benoit wrote:
>> In theory that patch should not be even needed.
>
> In theory that change is needed to fix the obviously broken code which
> is there at the moment.
>
> So, irrespective of whether OF gets permanently enabled or not, that ifdef
> needs to go.
>
> But, forcing OF on at this point probably isn't a good idea (who knows
> what else is lurking there) and there's a fairly simple and tested fix
> for this as I've shown in my OMAP patch.
>
> That, I feel, is likely to have less side effects than force enabling
> USE_OF.

+1. Fix the obvious bug in 3.3. In 3.4 this hunk of code is going to
be replaced anyway.

g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.