Re: OMAP34xx

Russell King - ARM Linux
2012-04-05T08:49:43Z

On Thu, Apr 05, 2012 at 02:04:41PM +0530, Archit Taneja wrote:
> We figured out the culprit patch, reverting this prevents the issue:
>
> commit 46f8c3c7e95c0d30d95911e7975ddc4f93b3e237
> Author: Archit Taneja <archit@ti.com>
> Date: Fri Oct 7 03:08:44 2011 -0600
>
> ARM: OMAP: ctrl: Fix CONTROL_DSIPHY register fields
>
> Fix the shift and mask macros for DSIx_PPID fields in
> CONTROL_DSIPHY. The
> OMAP4430 Public TRM vV has these fields mentioned correctly.
>
> Signed-off-by: Archit Taneja <archit@ti.com>
> Acked-by: Benoit Cousson <b-cousson@ti.com>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
>
>
> This was added to be in sync with the register definitions in newer
> OMAP4 TRMs. But it turns out that the newer TRMs might be actually
> messing up the register fields in question.

Okay, I've just tried reverting this commit, and the errors have gone.
However, I still see nothing on either display at boot time - not even
the backlight seems to be on. Should I see anything on the displays?