From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tero Kristo Subject: Re: [PATCHv2 7/8] arm: omap: clockdomain: add support for preventing domain transitions Date: Thu, 16 Feb 2012 10:39:09 +0200 Message-ID: <1329381549.4102.381.camel@sokoban> References: <1329320274-481-1-git-send-email-t-kristo@ti.com> <1329320274-481-8-git-send-email-t-kristo@ti.com> <87vcn799g8.fsf@ti.com> Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:47716 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754878Ab2BPIjX (ORCPT ); Thu, 16 Feb 2012 03:39:23 -0500 In-Reply-To: <87vcn799g8.fsf@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: linux-omap@vger.kernel.org, paul@pwsan.com, tony@atomide.com, linux-arm-kernel@lists.infradead.org On Wed, 2012-02-15 at 11:35 -0800, Kevin Hilman wrote: > Tero Kristo writes: > > > Some clockdomains can't support manual domain transitions triggered by > > clock framework, and must be prevented from doing so. Added clkdm flag > > CLKDM_NO_MANUAL_TRANS for doing this. > > > > Signed-off-by: Tero Kristo > > Cc: Paul Walmsley > > Cc: Kevin Hilman > > Dumb Q: what's the difference between this new flag and CLKDM_CAN_SWSUP? CAN_SWSUP controls software wakeup / sleep (clktrctrl values 1 and 2), but it still allows hwsup based transitions during runtime (basically using values 0 & 3 for the same register.) NO_MANUAL_TRANS prevents both, but still allows hwauto mode being enabled in the first place. I was thinking about adding a flag for preventing the autodep disabling as this was the root cause for the problem I saw, but I wanted to optimize the _clkdm_clk_hwmod_enable/disable for this case, as the domain is not going through any transitions. -Tero