From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCHv2 7/8] arm: omap: clockdomain: add support for
 preventing domain transitions
Date: Thu, 16 Feb 2012 10:58:26 +0200
Message-ID: <1329382706.4102.387.camel@sokoban>
References: <1329320274-481-1-git-send-email-t-kristo@ti.com>
	 <1329320274-481-8-git-send-email-t-kristo@ti.com> <87vcn799g8.fsf@ti.com>
	 <1329381549.4102.381.camel@sokoban>
	 <CAMQu2gwjfBd2ybKhEj+1Y1+b4yT+9i-DomozuxCMpKgcSfm9Gw@mail.gmail.com>
Reply-To: <t-kristo@ti.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <linux-omap-owner@vger.kernel.org>
Received: from bear.ext.ti.com ([192.94.94.41]:44898 "EHLO bear.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755949Ab2BPI6f (ORCPT <rfc822;linux-omap@vger.kernel.org>);
	Thu, 16 Feb 2012 03:58:35 -0500
In-Reply-To: <CAMQu2gwjfBd2ybKhEj+1Y1+b4yT+9i-DomozuxCMpKgcSfm9Gw@mail.gmail.com>
Sender: linux-omap-owner@vger.kernel.org
List-Id: linux-omap@vger.kernel.org
To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: Kevin Hilman <khilman@ti.com>, linux-omap@vger.kernel.org, paul@pwsan.com, tony@atomide.com, linux-arm-kernel@lists.infradead.org

On Thu, 2012-02-16 at 14:13 +0530, Shilimkar, Santosh wrote:
> Tero,
> On Thu, Feb 16, 2012 at 2:09 PM, Tero Kristo <t-kristo@ti.com> wrote:
> > On Wed, 2012-02-15 at 11:35 -0800, Kevin Hilman wrote:
> >> Tero Kristo <t-kristo@ti.com> writes:
> >>
> >> > Some clockdomains can't support manual domain transitions triggered by
> >> > clock framework, and must be prevented from doing so. Added clkdm flag
> >> > CLKDM_NO_MANUAL_TRANS for doing this.
> >> >
> >> > Signed-off-by: Tero Kristo <t-kristo@ti.com>
> >> > Cc: Paul Walmsley <paul@pwsan.com>
> >> > Cc: Kevin Hilman <khilman@ti.com>
> >>
> >> Dumb Q: what's the difference between this new flag and CLKDM_CAN_SWSUP?
> >
> > CAN_SWSUP controls software wakeup / sleep (clktrctrl values 1 and 2),
> > but it still allows hwsup based transitions during runtime (basically
> > using values 0 & 3 for the same register.) NO_MANUAL_TRANS prevents
> > both, but still allows hwauto mode being enabled in the first place.
> >
> > I was thinking about adding a flag for preventing the autodep disabling
> > as this was the root cause for the problem I saw, but I wanted to
> > optimize the _clkdm_clk_hwmod_enable/disable for this case, as the
> > domain is not going through any transitions.
> >
> Which clock-domain you are refering here which needs this
> flag ?

per_clkdm, see patch 8 in this same set for comments. This happens with
omap3.

> 
> Regards
> santosh