From: Rajendra Nayak <rnayak@ti.com>
To: tony@atomide.com
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Rajendra Nayak <rnayak@ti.com>, Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org
Subject: [PATCH 3/6] mmc: omap_hsmmc: If probe fails, give out error messages
Date: Fri, 24 Feb 2012 15:28:54 +0530 [thread overview]
Message-ID: <1330077537-19618-4-git-send-email-rnayak@ti.com> (raw)
In-Reply-To: <1330077537-19618-1-git-send-email-rnayak@ti.com>
Giving out debug messages even in case of probe failure seems
not very useful. Make them error messages instead.
Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Cc: Chris Ball <cjb@laptop.org>
Cc: <linux-mmc@vger.kernel.org>
---
drivers/mmc/host/omap_hsmmc.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 21b8afa..653ffee 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2008,13 +2008,13 @@ static int omap_hsmmc_probe(struct platform_device *pdev)
ret = request_irq(host->irq, omap_hsmmc_irq, 0,
mmc_hostname(mmc), host);
if (ret) {
- dev_dbg(mmc_dev(host->mmc), "Unable to grab HSMMC IRQ\n");
+ dev_err(mmc_dev(host->mmc), "Unable to grab HSMMC IRQ\n");
goto err_irq;
}
if (pdata->init != NULL) {
if (pdata->init(&pdev->dev) != 0) {
- dev_dbg(mmc_dev(host->mmc),
+ dev_err(mmc_dev(host->mmc),
"Unable to configure MMC IRQs\n");
goto err_irq_cd_init;
}
@@ -2037,7 +2037,7 @@ static int omap_hsmmc_probe(struct platform_device *pdev)
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
mmc_hostname(mmc), host);
if (ret) {
- dev_dbg(mmc_dev(host->mmc),
+ dev_err(mmc_dev(host->mmc),
"Unable to grab MMC CD IRQ\n");
goto err_irq_cd;
}
--
1.7.1
next prev parent reply other threads:[~2012-02-24 9:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 9:58 [PATCH 0/6] Fix issues around twl4030-gpio used as a module Rajendra Nayak
2012-02-24 9:58 ` [PATCH 1/6] ARM: OMAP: omap_device: Add omap_device_unregister() Rajendra Nayak
2012-02-24 9:58 ` [PATCH 2/6] mmc: omap_hsmmc: Make the driver support hotpluggable devices Rajendra Nayak
2012-02-24 9:58 ` Rajendra Nayak [this message]
2012-02-24 9:58 ` [PATCH 4/6] ARM: OMAP3: Mark only those mmc devices which use gpio_cd, as deferred Rajendra Nayak
2012-02-24 22:21 ` Tony Lindgren
2012-02-25 4:30 ` Rajendra Nayak
2012-02-24 9:58 ` [PATCH 5/6] ARM: OMAP3: Modify omap_hsmmc_late_init to handle deleting mmc devices Rajendra Nayak
2012-02-25 0:33 ` Tony Lindgren
2012-02-25 4:45 ` Rajendra Nayak
2012-03-01 18:58 ` Tony Lindgren
2012-02-24 9:58 ` [PATCH 6/6] ARM: OMAP3: Use .teardown of twl4030-gpio to clean board requests Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330077537-19618-4-git-send-email-rnayak@ti.com \
--to=rnayak@ti.com \
--cc=cjb@laptop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).