From: Tero Kristo <t-kristo@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Liam Girdwood <lrg@ti.com>, Samuel Ortiz <sameo@linux.intel.com>,
Kevin Hilman <khilman@ti.com>
Subject: Re: [PATCH] regulator: twl6030: add support for vdd1, vdd2 and vdd3 regulators
Date: Fri, 24 Feb 2012 16:42:12 +0200 [thread overview]
Message-ID: <1330094532.4102.555.camel@sokoban> (raw)
In-Reply-To: <20120224143415.GL5450@opensource.wolfsonmicro.com>
On Fri, 2012-02-24 at 14:34 +0000, Mark Brown wrote:
> On Fri, Feb 24, 2012 at 04:25:12PM +0200, Tero Kristo wrote:
>
> > Still, setting selector in this case does nothing, as it is immediately
> > overwritten by the regulator core by -1. This looks like a perfectly
> > acceptable way to implement a regulator, as everything checks for the
> > presence of list_voltage anyway.
>
> Ah, so it is - we're fixing things up in the core. I'd forgotten we did
> that.
So, no need to add list_voltage to this, I just fix the return values
for the get / set and send the new version, am I right?
-Tero
next prev parent reply other threads:[~2012-02-24 14:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 11:05 [PATCH] regulator: twl6030: add support for vdd1, vdd2 and vdd3 regulators Tero Kristo
2012-02-23 15:34 ` Mark Brown
2012-02-24 9:38 ` Tero Kristo
2012-02-24 11:49 ` Mark Brown
2012-02-24 13:16 ` Tero Kristo
2012-02-24 13:24 ` Mark Brown
2012-02-24 13:56 ` Tero Kristo
2012-02-24 14:01 ` Mark Brown
2012-02-24 14:25 ` Tero Kristo
2012-02-24 14:34 ` Mark Brown
2012-02-24 14:42 ` Tero Kristo [this message]
2012-02-24 14:50 ` Mark Brown
2012-02-24 15:04 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330094532.4102.555.camel@sokoban \
--to=t-kristo@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).